PE-7636: feat(login) enhance authentication error handling #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vements - Added GraphQL exception handling in authentication methods to throw custom exceptions. - Renamed `AuthenticationFailedException` to `WrongPasswordException` for clarity. - Introduced new states in the login bloc for loading and success scenarios when a user already exists. - Updated the login process to handle Ethereum and Arweave wallets separately with improved error handling. - Enhanced the UI to show progress dialogs during login and added a button to copy logs for error reporting. - Updated tests to reflect changes in exception handling and new state management. - Minor formatting and code cleanup across various files.
|
|
1 similar comment
|
|
thiagocarvalhodev
changed the title
thiagocarvalhodev
changed the title
|
Visit the preview URL for this PR (updated for commit c7b43a3): https://ardrive-web--pr1974-pe-7636-improve-erro-4q6ugoo6.web.app (expires Fri, 21 Feb 2025 14:16:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a224ebaee2f0939e7665e7630e7d3d6cd7d0f8b0 |
- extend error handling for arconnect and metamask - update wander assets
- extend error handling for arconnect and metamask - update wander assets
- extend error handling for arconnect and metamask - update wander assets
…6-improve-error-feedback-on-login-page-for-graph-ql-or-network-issues]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the login UX by showing appropriate messages for different login errors. Currently, the app always shows the 'wrong password' message for any error. Now, it will only show the wrong password message if indeed the password is wrong. For gateway related issues we're adding a new modal, same for unknown issues.
AuthenticationFailedExceptiontoWrongPasswordExceptionfor clarity.--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/026ju0acc3kv0