Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming Release Changes #1946

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Upcoming Release Changes #1946

merged 1 commit into from
Jan 10, 2025

Conversation

theguild-bot
Copy link
Collaborator

@theguild-bot theguild-bot commented Jan 7, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@whatwg-node/[email protected]

Patch Changes

@whatwg-node/[email protected]

Patch Changes

  • #1929
    b88b85c
    Thanks @ardatan! - dependencies updates:

  • #1947
    9b39c3e
    Thanks @ardatan! - Remove the event listener on the provided
    AbortSignal when node-libcurl is used, the connection finishes to prevent potential memory
    leaks;

    const res = await fetch(URL, { signal: new AbortController().signal })
    // AbortController is never aborted, and HTTP request is done as expected successfully
  • #1929
    b88b85c
    Thanks @ardatan! - - Remove URL ponyfill implementation based on
    fast-url-parser and fast-querystring, because Node now uses Ada URL parser which is fast
    enough.

    • Fix ReadableStream[Symbol.asyncIterator]

    ReadableStream uses Readable so it uses Symbol.asyncIterator method of Readable but the
    returned iterator's .return method doesn't handle cancellation correctly. So we need to call
    readable.destroy(optionalError) manually to cancel the stream.

    This allows ReadableStream to use implementations relying on AsyncIterable.cancel to handle
    cancellation like Readable.from

    Previously the following was not handling cancellation;

    const res = new ReadableStream({
      start(controller) {
        controller.enqueue('Hello')
        controller.enqueue('World')
      },
      cancel(reason) {
        console.log('cancelled', reason)
      }
    })
    
    const readable = Readable.from(res)
    
    readable.destroy(new Error('MY REASON'))
    
    // Should log 'cancelled MY REASON'

@e2e/[email protected]

Patch Changes

@e2e/[email protected]

Patch Changes

@e2e/[email protected]

Patch Changes

@theguild-bot theguild-bot force-pushed the changeset-release/master branch from 8c7c37e to e2d11b6 Compare January 7, 2025 14:10
Copy link
Contributor

github-actions bot commented Jan 7, 2025

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=140.193355 min=20      med=140     max=189     p(90)=162     p(95)=166    
     data_received..................: 22 MB  730 kB/s
     data_sent......................: 14 MB  473 kB/s
     http_req_blocked...............: avg=4µs        min=651ns   med=1.33µs  max=9.14ms  p(90)=1.98µs  p(95)=2.23µs 
     http_req_connecting............: avg=668ns      min=0s      med=0s      max=3.08ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=20.89ms    min=2.84ms  med=20.31ms max=1.12s   p(90)=26.33ms p(95)=27.89ms
       { expected_response:true }...: avg=20.89ms    min=2.84ms  med=20.31ms max=1.12s   p(90)=26.33ms p(95)=27.89ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 143139
     http_req_receiving.............: avg=32.59µs    min=8.76µs  med=22.52µs max=17.54ms p(90)=36.71µs p(95)=43.84µs
     http_req_sending...............: avg=10.77µs    min=3.35µs  med=6.33µs  max=7.91ms  p(90)=9.59µs  p(95)=13.5µs 
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=20.85ms    min=2.8ms   med=20.27ms max=1.12s   p(90)=26.29ms p(95)=27.83ms
     http_reqs......................: 143139 4770.666281/s
     iteration_duration.............: avg=41.89ms    min=13.48ms med=40.36ms max=1.14s   p(90)=45.61ms p(95)=51.77ms
     iterations.....................: 71547  2384.58324/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Jan 7, 2025

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=140.344762 min=12      med=141     max=196     p(90)=159     p(95)=163    
     data_received..................: 21 MB  710 kB/s
     data_sent......................: 14 MB  455 kB/s
     http_req_blocked...............: avg=1.95µs     min=601ns   med=1.22µs  max=4.06ms  p(90)=2µs     p(95)=2.24µs 
     http_req_connecting............: avg=218ns      min=0s      med=0s      max=1.17ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=21.47ms    min=3.41ms  med=20.95ms max=1.13s   p(90)=26.93ms p(95)=28.33ms
       { expected_response:true }...: avg=21.47ms    min=3.41ms  med=20.95ms max=1.13s   p(90)=26.93ms p(95)=28.33ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 139266
     http_req_receiving.............: avg=31.88µs    min=9.17µs  med=22.41µs max=12.3ms  p(90)=36.14µs p(95)=43.07µs
     http_req_sending...............: avg=10.04µs    min=3.37µs  med=5.68µs  max=10.53ms p(90)=9.34µs  p(95)=12.76µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=21.43ms    min=3.38ms  med=20.91ms max=1.13s   p(90)=26.89ms p(95)=28.28ms
     http_reqs......................: 139266 4641.738563/s
     iteration_duration.............: avg=43.05ms    min=10.19ms med=41.5ms  max=1.15s   p(90)=46.98ms p(95)=52.73ms
     iterations.....................: 69619  2320.402661/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Jan 7, 2025

🚀 Snapshot Release (rc)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package Version Info
@whatwg-node/fetch 0.10.2-rc-20250110005821-29ebf3b51e1d4f70a36ae0c564ab3c595af6fce1 npm ↗︎ unpkg ↗︎
@whatwg-node/node-fetch 0.7.6-rc-20250110005821-29ebf3b51e1d4f70a36ae0c564ab3c595af6fce1 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Jan 7, 2025

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 209264      ✗ 0     
     data_received..................: 21 MB   701 kB/s
     data_sent......................: 8.4 MB  279 kB/s
     http_req_blocked...............: avg=1.39µs   min=861ns    med=1.19µs   max=178.43µs p(90)=1.88µs   p(95)=2.04µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=117.86µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=225.39µs min=169.94µs med=215.28µs max=7.35ms   p(90)=242.25µs p(95)=252.35µs
       { expected_response:true }...: avg=225.39µs min=169.94µs med=215.28µs max=7.35ms   p(90)=242.25µs p(95)=252.35µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 104632
     http_req_receiving.............: avg=25.22µs  min=13.77µs  med=23.68µs  max=2.52ms   p(90)=30.44µs  p(95)=33.52µs 
     http_req_sending...............: avg=6.23µs   min=4.02µs   med=5.43µs   max=357.12µs p(90)=7.98µs   p(95)=8.62µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=193.93µs min=146.33µs med=183.92µs max=7.25ms   p(90)=207.81µs p(95)=217.01µs
     http_reqs......................: 104632  3487.584015/s
     iteration_duration.............: avg=282.38µs min=214.25µs med=271.48µs max=7.43ms   p(90)=301.45µs p(95)=313.77µs
     iterations.....................: 104632  3487.584015/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

github-actions bot commented Jan 7, 2025

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 298048      ✗ 0     
     data_received..................: 29 MB   979 kB/s
     data_sent......................: 12 MB   397 kB/s
     http_req_blocked...............: avg=1.34µs   min=872ns    med=1.13µs   max=195.13µs p(90)=1.84µs   p(95)=2µs     
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=132.42µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=139.23µs min=95.3µs   med=134.66µs max=6.27ms   p(90)=156.61µs p(95)=163.73µs
       { expected_response:true }...: avg=139.23µs min=95.3µs   med=134.66µs max=6.27ms   p(90)=156.61µs p(95)=163.73µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 149024
     http_req_receiving.............: avg=24.27µs  min=12.16µs  med=22.77µs  max=3.03ms   p(90)=29.93µs  p(95)=32.77µs 
     http_req_sending...............: avg=6.22µs   min=4µs      med=5.37µs   max=281.4µs  p(90)=7.99µs   p(95)=8.76µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=108.73µs min=69.92µs  med=103.74µs max=6.18ms   p(90)=122.8µs  p(95)=128.7µs 
     http_reqs......................: 149024  4967.299494/s
     iteration_duration.............: avg=196.88µs min=140.86µs med=191.4µs  max=6.44ms   p(90)=216.74µs p(95)=225.9µs 
     iterations.....................: 149024  4967.299494/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

github-actions bot commented Jan 7, 2025

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 219574      ✗ 0     
     data_received..................: 22 MB   736 kB/s
     data_sent......................: 8.8 MB  293 kB/s
     http_req_blocked...............: avg=1.37µs   min=872ns    med=1.15µs   max=260.77µs p(90)=1.83µs   p(95)=2µs     
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=119.47µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=210.31µs min=156.09µs med=199.16µs max=44.79ms  p(90)=224.3µs  p(95)=233.14µs
       { expected_response:true }...: avg=210.31µs min=156.09µs med=199.16µs max=44.79ms  p(90)=224.3µs  p(95)=233.14µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 109787
     http_req_receiving.............: avg=25.75µs  min=13.86µs  med=23.91µs  max=5.51ms   p(90)=30.84µs  p(95)=33.62µs 
     http_req_sending...............: avg=6.42µs   min=4.03µs   med=5.65µs   max=307.9µs  p(90)=8.18µs   p(95)=8.84µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=178.13µs min=127.84µs med=167.14µs max=44.71ms  p(90)=189.46µs p(95)=197.46µs
     http_reqs......................: 109787  3659.427411/s
     iteration_duration.............: avg=268.76µs min=202.13µs med=256.58µs max=44.93ms  p(90)=285.15µs p(95)=296.18µs
     iterations.....................: 109787  3659.427411/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@theguild-bot theguild-bot force-pushed the changeset-release/master branch 9 times, most recently from 4a9c9e1 to a2fcc19 Compare January 9, 2025 19:42
@theguild-bot theguild-bot force-pushed the changeset-release/master branch from a2fcc19 to 29ebf3b Compare January 10, 2025 00:56
@ardatan ardatan merged commit 6dc3d3f into master Jan 10, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants