Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-fetch): WritableStream, TransformStream & CompressionStream #1495

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Jul 26, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Jul 26, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@whatwg-node/fetch 0.9.19-alpha-20240726021135-a38a9d63f58bdbee352065e80c526123c947841c npm ↗︎ unpkg ↗︎
@whatwg-node/node-fetch 0.5.16-alpha-20240726021135-a38a9d63f58bdbee352065e80c526123c947841c npm ↗︎ unpkg ↗︎
@whatwg-node/server 0.9.44-alpha-20240726021135-a38a9d63f58bdbee352065e80c526123c947841c npm ↗︎ unpkg ↗︎
@whatwg-node/server-plugin-cookies 1.0.3-alpha-20240726021135-a38a9d63f58bdbee352065e80c526123c947841c npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Jul 26, 2024

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=138.251473 min=13     med=138     max=202      p(90)=160     p(95)=166    
     data_received..................: 24 MB  805 kB/s
     data_sent......................: 16 MB  522 kB/s
     http_req_blocked...............: avg=2.51µs     min=621ns  med=1.48µs  max=5.73ms   p(90)=2.04µs  p(95)=2.46µs 
     http_req_connecting............: avg=525ns      min=0s     med=0s      max=5.7ms    p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=18.92ms    min=1.64ms med=18.48ms max=866.74ms p(90)=24.56ms p(95)=26.64ms
       { expected_response:true }...: avg=18.92ms    min=1.64ms med=18.48ms max=866.74ms p(90)=24.56ms p(95)=26.64ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 157934
     http_req_receiving.............: avg=37.33µs    min=8.44µs med=24.9µs  max=25.33ms  p(90)=40.19µs p(95)=48.89µs
     http_req_sending...............: avg=12.77µs    min=3.07µs med=7.2µs   max=28.25ms  p(90)=10.66µs p(95)=16.19µs
     http_req_tls_handshaking.......: avg=0s         min=0s     med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=18.87ms    min=1.61ms med=18.44ms max=866.65ms p(90)=24.51ms p(95)=26.56ms
     http_reqs......................: 157934 5263.956889/s
     iteration_duration.............: avg=37.96ms    min=8.28ms med=36.75ms max=886.03ms p(90)=42.37ms p(95)=47.83ms
     iterations.....................: 78947  2631.311842/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Jul 26, 2024

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=138.651147 min=13     med=136     max=202      p(90)=163     p(95)=169    
     data_received..................: 23 MB  781 kB/s
     data_sent......................: 15 MB  501 kB/s
     http_req_blocked...............: avg=2.76µs     min=642ns  med=1.32µs  max=6.42ms   p(90)=1.99µs  p(95)=2.24µs 
     http_req_connecting............: avg=886ns      min=0s     med=0s      max=6.28ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=19.51ms    min=1.42ms med=18.98ms max=852.48ms p(90)=25.36ms p(95)=27.02ms
       { expected_response:true }...: avg=19.51ms    min=1.42ms med=18.98ms max=852.48ms p(90)=25.36ms p(95)=27.02ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 153227
     http_req_receiving.............: avg=34.83µs    min=8.95µs med=23.88µs max=23.68ms  p(90)=38.75µs p(95)=46.67µs
     http_req_sending...............: avg=12.44µs    min=3.33µs med=6.29µs  max=22.67ms  p(90)=9.56µs  p(95)=14.72µs
     http_req_tls_handshaking.......: avg=0s         min=0s     med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=19.46ms    min=1.38ms med=18.94ms max=852.41ms p(90)=25.31ms p(95)=26.96ms
     http_reqs......................: 153227 5107.041292/s
     iteration_duration.............: avg=39.12ms    min=9.07ms med=37.91ms max=870.2ms  p(90)=43.22ms p(95)=49.39ms
     iterations.....................: 76591  2552.770723/s
     vus............................: 0      min=0         max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Jul 26, 2024

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 229840      ✗ 0     
     data_received..................: 23 MB   770 kB/s
     data_sent......................: 9.2 MB  306 kB/s
     http_req_blocked...............: avg=1.43µs   min=922ns    med=1.23µs   max=166.36µs p(90)=1.95µs   p(95)=2.13µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=116.87µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=198.8µs  min=152.77µs med=185.75µs max=13.47ms  p(90)=213.3µs  p(95)=223.94µs
       { expected_response:true }...: avg=198.8µs  min=152.77µs med=185.75µs max=13.47ms  p(90)=213.3µs  p(95)=223.94µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 114920
     http_req_receiving.............: avg=25.4µs   min=13.26µs  med=23.86µs  max=1.12ms   p(90)=31.04µs  p(95)=33.35µs 
     http_req_sending...............: avg=6.31µs   min=4µs      med=5.55µs   max=340.95µs p(90)=8.23µs   p(95)=8.9µs   
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=167.08µs min=122.78µs med=153.81µs max=13.4ms   p(90)=177.85µs p(95)=187.62µs
     http_reqs......................: 114920  3830.524759/s
     iteration_duration.............: avg=256.61µs min=203.67µs med=242.95µs max=13.61ms  p(90)=273.7µs  p(95)=287.05µs
     iterations.....................: 114920  3830.524759/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

github-actions bot commented Jul 26, 2024

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 301322      ✗ 0     
     data_received..................: 30 MB   989 kB/s
     data_sent......................: 12 MB   402 kB/s
     http_req_blocked...............: avg=1.38µs   min=901ns    med=1.2µs    max=257.38µs p(90)=1.84µs   p(95)=2µs     
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=117.15µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=138.34µs min=94.76µs  med=133.32µs max=9.37ms   p(90)=154.38µs p(95)=160.42µs
       { expected_response:true }...: avg=138.34µs min=94.76µs  med=133.32µs max=9.37ms   p(90)=154.38µs p(95)=160.42µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 150661
     http_req_receiving.............: avg=24.17µs  min=12.48µs  med=23.07µs  max=657.99µs p(90)=29.87µs  p(95)=31.8µs  
     http_req_sending...............: avg=6.2µs    min=4.03µs   med=5.45µs   max=265.61µs p(90)=8.05µs   p(95)=8.5µs   
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=107.96µs min=69.69µs  med=102.39µs max=9.34ms   p(90)=120.58µs p(95)=125.59µs
     http_reqs......................: 150661  5021.845446/s
     iteration_duration.............: avg=194.73µs min=138.99µs med=188.9µs  max=9.48ms   p(90)=212.73µs p(95)=220.89µs
     iterations.....................: 150661  5021.845446/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@ardatan ardatan merged commit bebc159 into master Jul 26, 2024
22 checks passed
This was referenced Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant