Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Vary: Origin header overwritten #1407

Merged
merged 3 commits into from
Jun 24, 2024
Merged

fix: Vary: Origin header overwritten #1407

merged 3 commits into from
Jun 24, 2024

Conversation

Akryum
Copy link
Contributor

@Akryum Akryum commented Jun 24, 2024

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

Reading the code, I stumbled on this code mistake where Vary: Origin would be overwritten by the Vary: Access-Control-Request-Headers because of a missing else.

Related # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • package-name:
  • NodeJS:

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...

@Akryum
Copy link
Contributor Author

Akryum commented Jun 24, 2024

This is a very simple change, should I create an issue?

@ardatan
Copy link
Owner

ardatan commented Jun 24, 2024

Thanks for the PR!
An issue is not needed but some test would be nice to prevent any future regressions.

@ardatan ardatan marked this pull request as ready for review June 24, 2024 13:17
@ardatan
Copy link
Owner

ardatan commented Jun 24, 2024

Could you also add a changeset using yarn changeset? Then we can merge and release!

@ardatan ardatan merged commit ebbc85b into ardatan:master Jun 24, 2024
17 checks passed
@Akryum Akryum deleted the patch-1 branch June 24, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants