Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): unique context objects per request #1246

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Apr 15, 2024

No description provided.

Copy link

codesandbox bot commented Apr 15, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

github-actions bot commented Apr 15, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@whatwg-node/server 0.9.33-alpha-20240415113302-e322e5febe74b3947e403216d703c01d0ad478ec npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Apr 15, 2024

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=138.34428 min=57       med=137     max=198      p(90)=163     p(95)=168    
     data_received..................: 24 MB  797 kB/s
     data_sent......................: 16 MB  516 kB/s
     http_req_blocked...............: avg=3.73µs    min=601ns    med=1.46µs  max=5.77ms   p(90)=2.03µs  p(95)=2.38µs 
     http_req_connecting............: avg=1.64µs    min=0s       med=0s      max=5.2ms    p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=19.11ms   min=1ms      med=18.57ms max=841.88ms p(90)=25.17ms p(95)=26.78ms
       { expected_response:true }...: avg=19.11ms   min=1ms      med=18.57ms max=841.88ms p(90)=25.17ms p(95)=26.78ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 156369
     http_req_receiving.............: avg=37.34µs   min=8.47µs   med=24.4µs  max=22.55ms  p(90)=39.89µs p(95)=48.73µs
     http_req_sending...............: avg=12.14µs   min=2.62µs   med=6.89µs  max=25.36ms  p(90)=10.34µs p(95)=16µs   
     http_req_tls_handshaking.......: avg=0s        min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=19.06ms   min=916.46µs med=18.53ms max=841.64ms p(90)=25.12ms p(95)=26.71ms
     http_reqs......................: 156369 5211.826581/s
     iteration_duration.............: avg=38.34ms   min=5.68ms   med=37.28ms max=862.67ms p(90)=42.37ms p(95)=47.48ms
     iterations.....................: 78166  2605.29668/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Apr 15, 2024

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=139.331793 min=13       med=140     max=195      p(90)=161     p(95)=166    
     data_received..................: 22 MB  742 kB/s
     data_sent......................: 14 MB  475 kB/s
     http_req_blocked...............: avg=2.75µs     min=591ns    med=1.4µs   max=8.74ms   p(90)=2.05µs  p(95)=2.4µs  
     http_req_connecting............: avg=890ns      min=0s       med=0s      max=5.11ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=20.54ms    min=614.62µs med=20ms    max=879.2ms  p(90)=26.57ms p(95)=28.18ms
       { expected_response:true }...: avg=20.54ms    min=614.62µs med=20ms    max=879.2ms  p(90)=26.57ms p(95)=28.18ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 145470
     http_req_receiving.............: avg=37.26µs    min=9.47µs   med=24.99µs max=25.38ms  p(90)=40.23µs p(95)=48.49µs
     http_req_sending...............: avg=13.22µs    min=3.46µs   med=7.07µs  max=21.79ms  p(90)=10.44µs p(95)=15.34µs
     http_req_tls_handshaking.......: avg=0s         min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=20.49ms    min=587.23µs med=19.96ms max=879.09ms p(90)=26.52ms p(95)=28.1ms 
     http_reqs......................: 145470 4848.106013/s
     iteration_duration.............: avg=41.2ms     min=8.17ms   med=40.01ms max=914.07ms p(90)=45.31ms p(95)=51.03ms
     iterations.....................: 72711  2423.253154/s
     vus............................: 1      min=1         max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

@benchmarks/server results

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 268282      ✗ 0     
     data_received..................: 26 MB   881 kB/s
     data_sent......................: 11 MB   358 kB/s
     http_req_blocked...............: avg=1.51µs   min=822ns    med=1.41µs   max=221.56µs p(90)=1.97µs   p(95)=2.2µs   
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=149.83µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=153.49µs min=98.68µs  med=145µs    max=11.31ms  p(90)=165.82µs p(95)=172.78µs
       { expected_response:true }...: avg=153.49µs min=98.68µs  med=145µs    max=11.31ms  p(90)=165.82µs p(95)=172.78µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 134141
     http_req_receiving.............: avg=25.13µs  min=12.36µs  med=23.64µs  max=2.95ms   p(90)=30.83µs  p(95)=33.01µs 
     http_req_sending...............: avg=7.29µs   min=4.1µs    med=7.3µs    max=11.11ms  p(90)=8.84µs   p(95)=10.4µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=121.06µs min=73.18µs  med=112.85µs max=9.64ms   p(90)=130.28µs p(95)=136.01µs
     http_reqs......................: 134141  4471.157271/s
     iteration_duration.............: avg=218.68µs min=145.11µs med=209.62µs max=11.42ms  p(90)=233.77µs p(95)=243.88µs
     iterations.....................: 134141  4471.157271/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@ardatan ardatan merged commit 4717be5 into master Apr 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant