Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): set reason in ServerAdapterRequestAbortSignal to get a proper error message when aborted #1218

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Mar 21, 2024

No description provided.

Copy link

codesandbox bot commented Mar 21, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

github-actions bot commented Mar 21, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@whatwg-node/node-fetch 0.5.9-alpha-20240321101544-d4f6a3ec1f0c24888b6904208dd4cf1631c3f085 npm ↗︎ unpkg ↗︎
@whatwg-node/server 0.9.30-alpha-20240321101544-d4f6a3ec1f0c24888b6904208dd4cf1631c3f085 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Mar 21, 2024

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=140.041171 min=60       med=140     max=201      p(90)=158     p(95)=163    
     data_received..................: 24 MB  787 kB/s
     data_sent......................: 15 MB  510 kB/s
     http_req_blocked...............: avg=3.5µs      min=661ns    med=1.43µs  max=6.67ms   p(90)=2.02µs  p(95)=2.25µs 
     http_req_connecting............: avg=1.69µs     min=0s       med=0s      max=6.64ms   p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=19.37ms    min=217.59µs med=19.07ms max=812.9ms  p(90)=24.93ms p(95)=26.77ms
       { expected_response:true }...: avg=19.37ms    min=217.59µs med=19.07ms max=812.9ms  p(90)=24.93ms p(95)=26.77ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 154369
     http_req_receiving.............: avg=41.19µs    min=8.59µs   med=26.07µs max=22.86ms  p(90)=41.68µs p(95)=50.36µs
     http_req_sending...............: avg=11.29µs    min=2.77µs   med=6.4µs   max=25.09ms  p(90)=9.41µs  p(95)=14.26µs
     http_req_tls_handshaking.......: avg=0s         min=0s       med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=19.32ms    min=192.88µs med=19.03ms max=812.8ms  p(90)=24.88ms p(95)=26.69ms
     http_reqs......................: 154369 5145.330434/s
     iteration_duration.............: avg=38.84ms    min=9.16ms   med=37.78ms max=829.68ms p(90)=42.48ms p(95)=47.34ms
     iterations.....................: 77166  2572.048587/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Mar 21, 2024

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=140.026333 min=42      med=142     max=202      p(90)=158     p(95)=164    
     data_received..................: 23 MB  765 kB/s
     data_sent......................: 15 MB  491 kB/s
     http_req_blocked...............: avg=2.45µs     min=761ns   med=1.23µs  max=10.99ms  p(90)=1.95µs  p(95)=2.15µs 
     http_req_connecting............: avg=719ns      min=0s      med=0s      max=10.89ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=19.93ms    min=2.4ms   med=19.61ms max=869.48ms p(90)=25.46ms p(95)=26.61ms
       { expected_response:true }...: avg=19.93ms    min=2.4ms   med=19.61ms max=869.48ms p(90)=25.46ms p(95)=26.61ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 150048
     http_req_receiving.............: avg=32.92µs    min=9.46µs  med=24.51µs max=16.54ms  p(90)=39.5µs  p(95)=46.43µs
     http_req_sending...............: avg=9.76µs     min=2.89µs  med=5.37µs  max=23.54ms  p(90)=8.47µs  p(95)=12.18µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=19.89ms    min=2.35ms  med=19.57ms max=869.41ms p(90)=25.41ms p(95)=26.56ms
     http_reqs......................: 150048 5001.329854/s
     iteration_duration.............: avg=39.95ms    min=12.03ms med=38.91ms max=900.33ms p(90)=42.73ms p(95)=47.07ms
     iterations.....................: 75000  2499.86497/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

github-actions bot commented Mar 21, 2024

@benchmarks/server results

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 302374      ✗ 0     
     data_received..................: 30 MB   993 kB/s
     data_sent......................: 12 MB   403 kB/s
     http_req_blocked...............: avg=1.37µs   min=891ns   med=1.19µs   max=203.86µs p(90)=1.83µs   p(95)=1.98µs  
     http_req_connecting............: avg=0ns      min=0s      med=0s       max=123.63µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=137.98µs min=94.69µs med=133.52µs max=10.19ms  p(90)=154.89µs p(95)=161.57µs
       { expected_response:true }...: avg=137.98µs min=94.69µs med=133.52µs max=10.19ms  p(90)=154.89µs p(95)=161.57µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 151187
     http_req_receiving.............: avg=25.24µs  min=12.59µs med=24.03µs  max=5.2ms    p(90)=31.22µs  p(95)=33.19µs 
     http_req_sending...............: avg=5.83µs   min=3.65µs  med=5.19µs   max=235.01µs p(90)=7.52µs   p(95)=7.93µs  
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=106.89µs min=69.84µs med=101.95µs max=10.07ms  p(90)=120.4µs  p(95)=125.65µs
     http_reqs......................: 151187  5039.521068/s
     iteration_duration.............: avg=192.73µs min=138.1µs med=187.14µs max=10.58ms  p(90)=211.71µs p(95)=220.27µs
     iterations.....................: 151187  5039.521068/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@ardatan ardatan merged commit 1443f93 into master Mar 21, 2024
21 checks passed
@ardatan ardatan deleted the abort-signal-reason branch March 21, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant