Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printWithComments #3124

Merged
merged 7 commits into from
Jul 14, 2021
Merged

Fix printWithComments #3124

merged 7 commits into from
Jul 14, 2021

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Jul 1, 2021

Here printWithComments returns [Object object]
https://github.com/ardatan/graphql-tools/blob/master/packages/load/src/load-typedefs/parse.ts#L87

@dotansimha @gilgardosh
Sorry I pushed merge commit by mistake :/

@ardatan ardatan changed the title Reproduction print with comments Reproduction of the issue with printWithComments Jul 1, 2021
@theguild-bot
Copy link
Collaborator

theguild-bot commented Jul 1, 2021

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]
@graphql-tools/[email protected]

@ardatan ardatan force-pushed the reproduction-print-with-comments branch from 5374e2e to dfc8d3c Compare July 1, 2021 10:04
@ardatan ardatan force-pushed the reproduction-print-with-comments branch from dfc8d3c to 1e979c9 Compare July 1, 2021 10:09
@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2021

⚠️ No Changeset found

Latest commit: 205a9ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ardatan ardatan changed the title Reproduction of the issue with printWithComments Fix printWithComments Jul 14, 2021
@ardatan ardatan merged commit 650c4a1 into master Jul 14, 2021
@ardatan ardatan deleted the reproduction-print-with-comments branch July 14, 2021 00:17
ardatan added a commit that referenced this pull request Jul 25, 2021
* Reproduction of printWithComments issue

* Fix tests

* Break tests

* temp fix

* Fix TSC Build

* comments fix

Co-authored-by: Dotan Simha <[email protected]>
Co-authored-by: gilgardosh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants