Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to full API for loadDocuments #1801

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Add link to full API for loadDocuments #1801

merged 1 commit into from
Jul 21, 2020

Conversation

magicmark
Copy link
Contributor

Spent a few hours debugging why loadDocuments wasn't working as expected - there's a default of filtering NON_OPERATION_KINDS in the options that I missed :(

I had only read this page - telling the user "hey watch out, there's some defaults to be aware of!" and linking to them would be great.

Thanks! :)

Thanks!

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@magicmark
Add link to full API for loadDocuments
83717ea 
Spent a few hours debugging why `loadDocuments` wasn't working as expected - there's a default of filtering NON_OPERATION_KINDS in the options that I missed :(

I had only read this page - telling the user "hey watch out, there's some defaults to be aware of!" and linking to them would be great.

Thanks! :)

Thanks!
@ardatan
Copy link
Owner

ardatan commented Jul 21, 2020

Thanks @magicmark !

@ardatan ardatan merged commit 0b6671e into ardatan:master Jul 21, 2020
@theguild-bot
Copy link
Collaborator

The latest changes of this PR are available as alpha in npm: 6.0.15-alpha-0b6671ec.0

Quickly update your package.json by running:

npx match-version @graphql-tools 6.0.15-alpha-0b6671ec.0

@ardatan ardatan added the docs Focuses on documentation changes label Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Focuses on documentation changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicmark @ardatan @theguild-bot