You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Actually the idea behind this executor is to support defer/stream, and the new features from the next graphql-js releases with the schemas created by any graphql version.
The executor also accepts signal: AbortSignal which allows us to cancel the execution (used in a Yoga plugin)
I think instead of dropping a peer dependency which would introduce a breaking change, we can basically support the old way of resolving the types as I did in this PR; #6280
Let me know what you think. And you can also check the alpha versions published by CI if you want to try it out before the patch release.
Hi GraphQL Tools team 👋 I'm using
@graphql-tools/executor
over in https://github.com/apollographql/graphql-testing-library and it's been super nice to use, so thanks :)One thing I noticed is that when using it with a peer dependency of
[email protected]
I'm getting the following error:Support for returning GraphQLObjectType from resolveType was removed in [email protected] please return type name instead.
This was surprising since
graphql
is listed as a peer dependency within the following range:graphql-tools/packages/executor/package.json
Lines 54 to 56 in f61518e
Given the error that's being thrown I'd expect the peer dependency range to not include v15 or below.
Edit: I see that execute.ts is copy pasted from graphql-js@16, so the peer dependency range is even more misleading here :)
The text was updated successfully, but these errors were encountered: