feat(executor): argument value parsing errors should return 400 (#4827)

* feat(executor): argument value parsing errors should return 400 * Satisfy v15 * Go * Go
ardatan · Nov 7, 2022 · c0639dd · c0639dd
1 parent 1270b75
commit c0639dd
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 3 deletions.
diff --git a/.changeset/thin-countries-tan.md b/.changeset/thin-countries-tan.md
@@ -0,0 +1,5 @@
+---
+'@graphql-tools/utils': minor
+---
+
+TypeError and all other GraphQLError s from argument value parsing should return 400
diff --git a/packages/executor/src/execution/execute.ts b/packages/executor/src/execution/execute.ts
@@ -230,7 +230,20 @@ export function execute<TData = any, TVariables = any, TContext = any>(
 
   // Return early errors if execution context failed.
   if (!('schema' in exeContext)) {
-    return { errors: exeContext };
+    return {
+      errors: exeContext.map(e => {
+        Object.defineProperty(e, 'extensions', {
+          value: {
+            ...e.extensions,
+            http: {
+              ...e.extensions?.['http'],
+              status: 400,
+            },
+          },
+        });
+        return e;
+      }),
+    };
   }
 
   return executeImpl(exeContext);
@@ -1256,7 +1269,20 @@ export function subscribe<TData = any, TVariables = any, TContext = any>(
 
   // Return early errors if execution context failed.
   if (!('schema' in exeContext)) {
-    return { errors: exeContext };
+    return {
+      errors: exeContext.map(e => {
+        Object.defineProperty(e, 'extensions', {
+          value: {
+            ...e.extensions,
+            http: {
+              ...e.extensions?.['http'],
+              status: 400,
+            },
+          },
+        });
+        return e;
+      }),
+    };
   }
 
   const resultOrStream = createSourceEventStreamImpl(exeContext);
@@ -1348,7 +1374,20 @@ export function createSourceEventStream(
 
   // Return early errors if execution context failed.
   if (!('schema' in exeContext)) {
-    return { errors: exeContext };
+    return {
+      errors: exeContext.map(e => {
+        Object.defineProperty(e, 'extensions', {
+          value: {
+            ...e.extensions,
+            http: {
+              ...e.extensions?.['http'],
+              status: 400,
+            },
+          },
+        });
+        return e;
+      }),
+    };
   }
 
   return createSourceEventStreamImpl(exeContext);