useGETForQueries was also activating GET for mutations (#4885)

* useGETForQueries was also activating GET for mutations

* Added test: should be a GET operation when useGETForQueries=true

* Added test: should be a GET operation when useGETForQueries=true

.changeset/four-icons-hammer.md

@@ -0,0 +1,5 @@
+---
+'@graphql-tools/executor-http': patch
+---
+
+useGETForQueries was also activating GET for mutations

packages/executors/http/src/index.ts

@@ -84,7 +84,7 @@ export function buildHTTPExecutor(options?: HTTPExecutorOptions): Executor<any,
     const operationAst = getOperationASTFromRequest(request);
     const operationType = operationAst.operation;
 
-    if (options?.useGETForQueries || (request.extensions?.useGETForQueries && operationType === 'query')) {
+    if ((options?.useGETForQueries || request.extensions?.useGETForQueries) && operationType === 'query') {
       method = 'GET';
     }
 

packages/executors/http/tests/buildHTTPExecutor.test.ts

@@ -0,0 +1,29 @@
+import { parse } from 'graphql';
+import { buildHTTPExecutor, SyncFetchFn } from '../src/index.js';
+
+describe('buildHTTPExecutor', () => {
+  it('should be a GET operation when useGETForQueries=true', async () => {
+    const syncFetch: SyncFetchFn = (input, init) => {
+      return {
+        ...new Response(),
+        url: input,
+        headers: new Headers(init?.headers),
+        text: () => JSON.stringify({ data: init }),
+      };
+    };
+
+    const executor = buildHTTPExecutor({
+      useGETForQueries: true,
+      fetch: syncFetch,
+    });
+
+    const mutation = parse(/* GraphQL */ `
+      mutation {
+        doSomething
+      }
+    `);
+
+    const res = executor({ document: mutation });
+    expect(res.data.method).toBe('POST');
+  });
+});