fix(wrap): transforming wrapped input fields (#4676)

* fix: Fixed Transforming wrapped input fields * chore: prettier changes * fix: Added unit test * fix: Refactored to use getNamedType * chore: Added changeset Co-authored-by: bruno.ribeiro <[email protected]>
ardatan · Aug 26, 2022 · 4e4fac0 · 4e4fac0
1 parent 4fe3d9c
commit 4e4fac0
Show file tree

Hide file tree

Showing 3 changed files with 65 additions and 5 deletions.
diff --git a/.changeset/violet-kiwis-doubt.md b/.changeset/violet-kiwis-doubt.md
@@ -0,0 +1,5 @@
+---
+'@graphql-tools/wrap': patch
+---
+
+Fix transforming/renaming Wrapped GraphQL Arguments
diff --git a/packages/wrap/src/transforms/TransformInputObjectFields.ts b/packages/wrap/src/transforms/TransformInputObjectFields.ts
@@ -7,15 +7,15 @@ import {
   visitWithTypeInfo,
   Kind,
   FragmentDefinitionNode,
-  GraphQLInputObjectType,
   ObjectValueNode,
   ObjectFieldNode,
   OperationDefinitionNode,
   isInputType,
   NamedTypeNode,
+  getNamedType,
 } from 'graphql';
 
-import { Maybe, ExecutionRequest, MapperKind, mapSchema, transformInputValue } from '@graphql-tools/utils';
+import { ExecutionRequest, MapperKind, mapSchema, transformInputValue } from '@graphql-tools/utils';
 
 import { Transform, DelegationContext, SubschemaConfig } from '@graphql-tools/delegate';
 
@@ -162,10 +162,9 @@ export default class TransformInputObjectFields<TContext = Record<string, any>>
       visitWithTypeInfo(typeInfo, {
         [Kind.OBJECT]: {
           leave: (node: ObjectValueNode): ObjectValueNode | undefined => {
-            // The casting is kind of legit here as we are in a visitor
-            const parentType = typeInfo.getInputType() as Maybe<GraphQLInputObjectType>;
+            const parentType = typeInfo.getInputType();
             if (parentType != null) {
-              const parentTypeName = parentType.name;
+              const parentTypeName = getNamedType(parentType).name;
               const newInputFields: Array<ObjectFieldNode> = [];
 
               for (const inputField of node.fields) {

diff --git a/packages/wrap/tests/transformRenameInputObjectFields.test.ts b/packages/wrap/tests/transformRenameInputObjectFields.test.ts
@@ -60,6 +60,62 @@ describe('RenameInputObjectFields', () => {
     expect(testData.field2).toBe('field2');
   });
 
+  test('renaming with non-null arguments works', async () => {
+    const schema = makeExecutableSchema({
+      typeDefs: /* GraphQL */ `
+        input InputObject {
+          field1: String
+          field2: String
+        }
+
+        type OutputObject {
+          field1: String
+          field2: String
+        }
+
+        type Query {
+          test(argument: InputObject!): OutputObject
+        }
+      `,
+      resolvers: {
+        Query: {
+          test: (_root, args) => {
+            return args.argument;
+          },
+        },
+      },
+    });
+
+    const transformedSchema = wrapSchema({
+      schema,
+      transforms: [
+        new RenameInputObjectFields((typeName, fieldName) => {
+          if (typeName === 'InputObject' && fieldName === 'field2') {
+            return 'field3';
+          }
+        }),
+      ],
+    });
+
+    const query = /* GraphQL */ `
+      {
+        test(argument: { field1: "field1", field3: "field2" }) {
+          field1
+          field2
+        }
+      }
+    `;
+
+    const result = await execute({
+      schema: transformedSchema,
+      document: parse(query),
+    });
+    assertSome(result.data);
+    const testData: any = result.data['test'];
+    expect(testData.field1).toBe('field1');
+    expect(testData.field2).toBe('field2');
+  });
+
   test('renaming with variables works', async () => {
     const schema = makeExecutableSchema({
       typeDefs: /* GraphQL */ `