Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce mergeSchemas #19

Merged
merged 4 commits into from
Feb 13, 2019
Merged

Introduce mergeSchemas #19

merged 4 commits into from
Feb 13, 2019

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Feb 12, 2019

Introduce mergeSchemas with better features than mergeSchemas of graphql-tools such as keeping schema directives, adding required scalars etc.
Change mergeGraphQLSchemas to mergeTypeDefs

@ardatan ardatan requested a review from dotansimha February 12, 2019 21:16
@dotansimha
Copy link
Collaborator

@ardatan in general it looks good. It's a breaking change, right? the API has changed.
I think maybe we can keep mergeGraphQlSchemas with the same API and call mergeTypeDefs, just for compatibility, and mark mergeGraphQlSchemas as deprecated.

@ardatan
Copy link
Owner Author

ardatan commented Feb 13, 2019

Done @dotansimha !

@dotansimha dotansimha merged commit 5d1079c into master Feb 13, 2019
@dotansimha dotansimha deleted the merge-schemas branch February 13, 2019 12:08
@ardatan ardatan mentioned this pull request Feb 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotansimha dotansimha dotansimha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ardatan @dotansimha