refactor: Removing all dependency to Guard.NET. #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for arcus-webapi canceled.
|
joachimgoris
changed the title
joachimgoris
requested review from
stijnmoreels and
fgheysels
as code owners
stijnmoreels
requested changes
Jan 1, 2025
There was a problem hiding this comment.
Thx a lot for your work on this and your investment in Arcus! Greatly appriciated.
It's a big PR, so I'll write some comments here that are related to tons of files here:
- It's a Micorosft code style to place a blank linke between curly braces and the next (non-curly brace) line. Now, all the if statements are glued togehter, which conflicts the current style in the repo.
- In method overloads, we previously had several 'paranoia' checks which duplicated things. Especially now that we are responsible for the checks, it might be better to opt for a centralized approach and only check the values where there are used. It helps with clarity, too.
- There are a lot of places where argument names are set. I believe in lots of these cases, that is unnecessary.
...cus.WebApi.Logging.AzureFunctions/Extensions/IFunctionsWorkerApplicationBuilderExtensions.cs
Show resolved
Hide resolved
src/Arcus.WebApi.Logging.Core/Correlation/HttpCorrelationClientOptions.cs
Outdated
Show resolved
Hide resolved
src/Arcus.WebApi.Logging.Core/Correlation/HttpCorrelationInfoAccessor.cs
Outdated
Show resolved
Hide resolved
src/Arcus.WebApi.Logging/Extensions/IServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Arcus.WebApi.Security/Authentication/Certificates/CertificateAuthenticationConfigBuilder.cs
Outdated
Show resolved
Hide resolved
src/Arcus.WebApi.Security/Authentication/Certificates/CertificateAuthenticationValidator.cs
Outdated
Show resolved
Hide resolved
|
@stijnmoreels I believe I've made all the changes you've requested in your comments. Could you be so kind to review the PR again? |
stijnmoreels
reviewed
Jan 7, 2025
src/Arcus.WebApi.Logging.AzureFunctions/AzureFunctionsRequestTrackingMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Arcus.WebApi.Logging.Core/Correlation/CorrelationInfoUpstreamServiceOptions.cs
Outdated
Show resolved
Hide resolved
src/Arcus.WebApi.Logging.Core/Correlation/CorrelationInfoUpstreamServiceOptions.cs
Outdated
Show resolved
Hide resolved
src/Arcus.WebApi.Security/Authentication/Certificates/ConfigurationValidationLocation.cs
Outdated
Show resolved
Hide resolved
src/Arcus.WebApi.Security/Authentication/SharedAccessKey/SharedAccessKeyAuthenticationFilter.cs
Outdated
Show resolved
Hide resolved
fgheysels
reviewed
Jan 9, 2025
fgheysels
approved these changes
Jan 9, 2025
|
@stijnmoreels or @fgheysels I don't have write access to the repository so I'm not allowed to merge my own PR's 😄 |
Let me do it for you, thanks again for your contribution and hope to see you again in the (near) future :) |
|
It looks like we have some failing unittests. Can you have a look at it @joachimgoris ? |
|
@fgheysels unit tests are fixed. |
src/Arcus.WebApi.Logging.Core/Correlation/HttpCorrelationClientOptions.cs
Outdated
Show resolved
Hide resolved
src/Arcus.WebApi.Logging.Core/Correlation/HttpCorrelationClientOptions.cs
Outdated
Show resolved
Hide resolved
src/Arcus.WebApi.OpenApi.Extensions/OAuthAuthorizeOperationFilter.cs
Outdated
Show resolved
Hide resolved
src/Arcus.WebApi.OpenApi.Extensions/SharedAccessKeyAuthenticationOperationFilter.cs
Outdated
Show resolved
Hide resolved
src/Arcus.WebApi.OpenApi.Extensions/SharedAccessKeyAuthenticationOperationFilter.cs
Outdated
Show resolved
Hide resolved
…tOptions.cs Co-authored-by: Stijn Moreels <[email protected]>
…tOptions.cs Co-authored-by: Stijn Moreels <[email protected]>
…ter.cs Co-authored-by: Stijn Moreels <[email protected]>
…ionOperationFilter.cs Co-authored-by: Stijn Moreels <[email protected]>
…ionOperationFilter.cs Co-authored-by: Stijn Moreels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue 463. This PR removes all dependency on Guard.NET. All checks done by Guard.NET have been replaced with
ifchecks.Closes #463