Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in determing the exit status of last shell command #207

Merged
merged 1 commit into from
Jun 29, 2019
Merged

Fix a bug in determing the exit status of last shell command #207

merged 1 commit into from
Jun 29, 2019

Conversation

xulongwu4
Copy link
Contributor

The exit status of last shell command should be determined at the very beginning of the compile_prompt function.

@arcticicestudio arcticicestudio self-requested a review June 29, 2019 05:05
@arcticicestudio arcticicestudio self-assigned this Jun 29, 2019
@arcticicestudio arcticicestudio added this to the 0.1.0 milestone Jun 29, 2019
arcticicestudio
arcticicestudio approved these changes Jun 29, 2019
View reviewed changes
Copy link
Owner

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xulongwu4 👋, thanks for your contribution 👍
LGTM 😄

@arcticicestudio arcticicestudio merged commit 6f483af into arcticicestudio:develop Jun 29, 2019
@arcticicestudio arcticicestudio removed their assignment Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcticicestudio arcticicestudio arcticicestudio approved these changes

Assignees
No one assigned
Labels
snowblock-bash type-bug
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xulongwu4 @arcticicestudio