Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use granter and payer in simulation #119

Merged
merged 10 commits into from
Jul 5, 2024

Conversation

pyncz
Copy link
Member

@pyncz pyncz commented Jul 4, 2024

No description provided.

Copy link

codacy-production bot commented Jul 4, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-1.37% (target: -1.00%) 89.96%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (51874da) 1168 1133 97.00%
Head commit (8308d90) 1373 (+205) 1313 (+180) 95.63% (-1.37%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#119) 259 233 89.96%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@pyncz pyncz requested review from aelesbao and macku99 July 5, 2024 14:59
@pyncz pyncz marked this pull request as ready for review July 5, 2024 14:59
aelesbao
aelesbao previously approved these changes Jul 5, 2024
@pyncz pyncz requested a review from aelesbao July 5, 2024 16:08
@pyncz pyncz merged commit a54458c into main Jul 5, 2024
8 of 9 checks passed
@pyncz pyncz deleted the fix/devx-628-use-granter-in-simulation branch July 5, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants