Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elan-lean: follow RFC16 and update maintainer email #3658

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

megrxu
Copy link
Contributor

@megrxu megrxu commented Feb 24, 2024

Comment on lines 17 to 18
depends=('curl' 'xz')
makedepends=('cargo')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elan-lean W: ELF file ('usr/bin/elan') lacks GNU_PROPERTY_X86_FEATURE_1_SHSTK.
elan-lean E: Dependency bzip2 detected and not included (libraries ['usr/lib/libbz2.so.1.0'] needed in files ['usr/bin/elan'])
elan-lean W: Dependency glibc detected and implicitly satisfied (libraries ['usr/lib/ld-linux-x86-64.so.2', 'usr/lib/libm.so.6', 'usr/lib/libc.so.6'] needed in files ['usr/bin/elan'])
elan-lean W: Dependency gcc-libs detected and implicitly satisfied (libraries ['usr/lib/libgcc_s.so.1'] needed in files ['usr/bin/elan'])
elan-lean W: Dependency included, but may not be needed ('xz')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depends 问题好解决。但是 GNU_PROPERTY_X86_FEATURE_1_SHSTK 似乎 rust 项目不太好加 -fcf-protection?
好像只有 nightly 目前支持 -Z branch-protection
我 namcap 了 paru 的包,看起来也是这样的:

paru W: ELF file ('usr/bin/paru') lacks GNU_PROPERTY_X86_FEATURE_1_SHSTK.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiling elan-utils v1.11.0 (/build/elan-lean/src/elan-3.1.1/src/elan-utils)
warning: using `.clone()` on a double reference, which returns `&dyn for<'a> Fn(notifications::Notification<'a>)` instead of cloning the inner type
   --> src/elan-dist/src/dist.rs:209:32
    |
209 |         download.notify_handler.clone(),
    |                                ^^^^^^^^
    |
    = note: `#[warn(suspicious_double_ref_op)]` on by default

warning: `elan-dist` (lib) generated 1 warning

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个似乎是上游报的 warning,需要我们处理吗?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不用管的啦。

@Zenvie Zenvie merged commit 1d12812 into archlinuxcn:master Mar 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants