Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Wayfire support #3020

Merged
merged 2 commits into from
Dec 17, 2024
Merged

[Feat] Wayfire support #3020

merged 2 commits into from
Dec 17, 2024

Conversation

Mohamed-elg
Copy link
Contributor

@Mohamed-elg Mohamed-elg commented Dec 14, 2024

  • This solves issue: #2447

PR Description:

Add wayfire support option

Tests and Checks

  • I have tested the code!

@Mohamed-elg Mohamed-elg requested a review from Torxed as a code owner December 14, 2024 09:58
@svartkanin
Copy link
Collaborator

@Mohamed-elg thanks for the PR, could you address the comment and the indentation seems to be off

rchinstall/default_profiles/desktops/wayfire.py:8:0: W0311: Bad indentation. Found 4 tabs, expected 1 (bad-indentation)
archinstall/default_profiles/desktops/wayfire.py:9:0: W0311: Bad indentation. Found 8 tabs, expected 2 (bad-indentation)
archinstall/default_profiles/desktops/wayfire.py:11:0: W0311: Bad indentation. Found 4 tabs, expected 1 (bad-indentation)
archinstall/default_profiles/desktops/wayfire.py:12:0: W0311: Bad indentation. Found 4 tabs, expected 1 (bad-indentation)
archinstall/default_profiles/desktops/wayfire.py:13:0: W0311: Bad indentation. Found 4 tabs, expected 1 (bad-indentation)
archinstall/default_profiles/desktops/wayfire.py:14:0: W0311: Bad indentation. Found 8 tabs, expected 2 (bad-indentation)
archinstall/default_profiles/desktops/wayfire.py:1[6](https://github.com/archlinux/archinstall/actions/runs/12328898346/job/34461690899?pr=3020#step:9:7):0: W0311: Bad indentation. Found 4 tabs, expected 1 (bad-indentation)
archinstall/default_profiles/desktops/wayfire.py:1[7](https://github.com/archlinux/archinstall/actions/runs/12328898346/job/34461690899?pr=3020#step:9:8):0: W0311: Bad indentation. Found 4 tabs, expected 1 (bad-indentation)
archinstall/default_profiles/desktops/wayfire.py:18:0: W0311: Bad indentation. Found 4 tabs, expected 1 (bad-indentation)
archinstall/default_profiles/desktops/wayfire.py:19:0: W0311: Bad indentation. Found [8](https://github.com/archlinux/archinstall/actions/runs/12328898346/job/34461690899?pr=3020#step:9:9) tabs, expected 2 (bad-indentation)

@svartkanin svartkanin merged commit d2ef961 into archlinux:master Dec 17, 2024
8 checks passed
castillofrancodamian pushed a commit to castillofrancodamian/archinstall that referenced this pull request Dec 21, 2024
* add profile

* fix pylint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants