Add clarity to help menu #2802
Open
Add clarity to help menu #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svartkanin
reviewed
Nov 15, 2024
| parser.add_argument("--silent", action="store_true", | ||
| help="WARNING: Disables all prompts for input and confirmation. If no configuration is provided, this is ignored") | ||
| parser.add_argument("--dry-run", "--dry_run", action="store_true", | ||
| help="Generates a configuration file and then exits instead of performing an installation") | ||
| parser.add_argument("--script", default="guided", nargs="?", help="Script to run for installation", type=str) | ||
| parser.add_argument("--script", default="guided", nargs="?", help="Script to run for installation. Default: guided", type=str) |
There was a problem hiding this comment.
use the formatter instead so it is applied for all defaults
parser = ArgumentParser(formatter_class=argparse.ArgumentDefaultsHelpFormatter)
Torxed
approved these changes
Nov 15, 2024
|
The note about the default formatter would be nice, other than that this looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
The first few times I used the --config and --creds options with archinstall, I didn't even notice that the help menu said you could use a URL instead of a local file. This PR is intended to make that just a bit more obvious.
Tests and Checks
Here is a screenshot of the menu options using this branch:
