Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing crawl_date column to binary information jobs. #513

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Apr 29, 2021

GitHub issue(s): #512

What does this Pull Request do?

Add missing crawl_date column to binary information jobs.

How should this be tested?

  • GitHub actions should take care of it.

Additional Notes:

I'll cut a release once this is merged.

@ruebot ruebot requested a review from ianmilligan1 April 29, 2021 14:10
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #513 (b3ed9d2) into main (8104a65) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #513      +/-   ##
============================================
+ Coverage     88.83%   88.91%   +0.07%     
  Complexity       57       57              
============================================
  Files            43       43              
  Lines          1012     1019       +7     
  Branches         85       85              
============================================
+ Hits            899      906       +7     
  Misses           74       74              
  Partials         39       39              

@ianmilligan1 ianmilligan1 merged commit 2b1deb8 into main Apr 29, 2021
@ianmilligan1 ianmilligan1 deleted the issue-512 branch April 29, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crawl_date is not included on binary information jobs when documentation says it is
2 participants