Use new NeoForge reload listeners #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shedaniel
approved these changes
Feb 16, 2025
|
Thanks! |
7 tasks
ellellie
added a commit
to ellellie/RoughlyEnoughItems
that referenced
this pull request
Feb 16, 2025
Needed to update `ReloadListenerRegistry.register` calls due to architectury/architectury-api#603
shedaniel
pushed a commit
to shedaniel/RoughlyEnoughItems
that referenced
this pull request
Feb 16, 2025
* chore: update to Architectury API 15.0.2 Needed to update `ReloadListenerRegistry.register` calls due to architectury/architectury-api#603 * chore: add dependency on architectury >= 15.0.2 for the fabric platform. * chore: depend on NeoForge >= 21.4.84-beta as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change breaks mods that were using a null listenerId when calling
ReloadListenerRegistry.register(...), as NeoForge now requires that all listeners are named.Summary of changes:
ResourceLocation listenerIdis no longer@Nullable.ReloadListenerRegistryImplfor NeoForge now uses the appropriate events.21.4.84-beta.See neoforged/NeoForge#1915 for more information.