-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
force print log options and fix finding out the failed cy.commands or… #4
Conversation
If you are happy with this. I can update the README. |
This works wonder and exactly what my team need. Please kindly proceed with this. |
@zhex900 I have merged the tests into master. Please rebase and add a test for this case as well. You need to do an npm install in the tests directory and run npm run test. You will need a new cypress suite and in the test.js add a new test with mocha with the expectations. |
I will find some time to look at it over the weekend. My first open source contribution. |
Nice! It will wait your changes. |
All done. I have fix the problem of incorrect labeling of failed commands. The only things I don't know how to test. When I put a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhex900 I already wrote the test for FETCH API response for cy route and it works. You don't need to test that. You need to test only your added feature: the printLogs: always option.
All done. Please check. |
@zhex900 can you please check the remaining comments? |
Do you mean the README? I have updated that. |
No. The rest of the comments on the changes. Scroll up. There is one comment and one question. |
Sorry, I can't see any comments. |
@zhex900 Yes, sorry I actually did not relies that it was not submitted. You can check now. |
I have added an option to force print logs even when all tests passes.
Also I have changed from using the last command as the failed test to use
options.state
to check if the command failed or notFixes #3