Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TS): outputTarget function return type #223

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

bvandercar-vt
Copy link
Contributor

Doesn't need to return a string, even the example function for the custom logger does not return anything

@archfz
Copy link
Owner

archfz commented Nov 16, 2023

You have conflicts. On master the tests are passing, are you up to date? Also for some reason I don't have access to re-trigger tests on your branch.

@bvandercar-vt
Copy link
Contributor Author

@archfz

are you up to date?

Ah nope I was not! Fixed!

@archfz archfz merged commit 15d0f12 into archfz:master Nov 17, 2023
1 check passed
@bvandercar-vt bvandercar-vt deleted the fix-outputTarget-type branch November 7, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants