export public api / types used by installLogsPrinter / installLogsCollector #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tebeco
changed the title
|
@archfz if you have any leads on how changing a |
|
Looks good. I will retry the job. It most likely is flakiness. |
|
I have pushed some flakiness fixes for this test into develop. Please rebase and retarget your PR against develop. I would also prefer not to do a release only with this change. Could you maybe take a look into #127 as well? Would appreciate some fresh eyes. |
|
I wish github PR UI had a simple button to rebase. |
…he inner types should also be exported In order to properly be able to use an exported function, exporting the innertype would be more than usefull, as they are also part of the public API
|
@archfz, that seems to have fixed it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
installLogsPrinterandinstallLogsCollectorare exported, then the inner types should also be exported:installLogsPrinter.d.ts:PluginOptionsSeverityinstallLogsCollector.d.ts:SupportOptionsSeverityFunny note:
Severityis redundant and might be moved to a common place some day when the repo will be migrated to typescript, also the typpings would be emitted bytscso they would not need any manual maintainance