Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to write logs only to file avoiding print to terminal #47

Closed
sergeyKhristenko opened this issue Aug 28, 2020 · 9 comments
Closed
Assignees
Labels

Comments

@sergeyKhristenko
Copy link

I would like to have all the logs (not just onFail) in a file, having all of them printed to terminal looks too spammy. But it seems like print to terminal currently is inevitable. Is it possible to add some config option to print to file only?

@archfz
Copy link
Owner

archfz commented Aug 28, 2020

We should duplicate the option for when to write logs for file outputs. Also add additional option for those 'never'

@zvaehn
Copy link

zvaehn commented Sep 7, 2020

note that there are two different collectors.
One is called printer, the other one is the collector. (installLogsPrinter and installLogsCollector)
You can set the printer to "onFail" and the Collector to "always".

EDIT: Oh well, i just saw that this is no longer possible after updating to 2.0 since printLogs is not an allowed property anymore.

@archfz
Copy link
Owner

archfz commented Sep 7, 2020

@zvaehn What you are saying was not possible in previous versions either. Now we have proper validation on config to prevent you from sending unused config.

Also we dont have two collectors. There is only one collector which is in the support install, that collects the logs and later on sends it to the nod js (the plugin install / the printer) where they actually are written to console and file.

@zvaehn
Copy link

zvaehn commented Sep 7, 2020

Well, this sounds much more plausible. Thanks for pointing that out.
I am also interested in differenciating between console output and file-logging output.

@archfz
Copy link
Owner

archfz commented Sep 7, 2020

Will be comming in next minor release.

@rsudarson
Copy link

This is a useful feature. Can this be released sooner?

@flevi29
Copy link
Contributor

flevi29 commented Sep 25, 2020

I am working on it.

archfz added a commit that referenced this issue Oct 7, 2020
Add option to write logs only to file avoiding print to terminal #47
@archfz
Copy link
Owner

archfz commented Oct 7, 2020

Two new options coming up in next release that will replace current printLogs.

@archfz
Copy link
Owner

archfz commented Oct 8, 2020

Released in 2.1.0.

@archfz archfz closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants