Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: Cannot set property '2' of undefined #31

Closed
zvaehn opened this issue Jun 3, 2020 · 3 comments
Closed

Uncaught TypeError: Cannot set property '2' of undefined #31

zvaehn opened this issue Jun 3, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@zvaehn
Copy link

zvaehn commented Jun 3, 2020

I am getting this error when running all tests.
This does not occure in single runs.

I figured out that checking for undefined in here fixes the issue as well as resetting

logsChainId = {};

in the .on('test') callback here.

Looking forward to hear any feedback or see any fixes.

Best,
Sven

@archfz
Copy link
Owner

archfz commented Jun 3, 2020

Are you getting this only in tests? As I look at it this might be a real live issues. The problem I might see here is that we have the collect types and filter logs options that could make it so that those logs that get updated we dont store them actually.

So an easy fix would be just to simply check if there is that key in the logs.

@archfz archfz added the bug Something isn't working label Jun 3, 2020
@zvaehn
Copy link
Author

zvaehn commented Jun 4, 2020

Yes, i am only getting this in tests and if i edit the File as described above the error is gone.
Sure i could filter out error messages but this is more like a workaround.
I don't know the code as good as you do, so i hoped that you might approve my fix suggestions, knowing that this is just a check to prevent the error, not resolving the error in its origin.

@archfz archfz self-assigned this Jun 8, 2020
archfz added a commit that referenced this issue Jun 8, 2020
@archfz
Copy link
Owner

archfz commented Jun 14, 2020

Released in 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants