Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associations/collections with undefined properties when columns not present in result set #35

Open
VividVisions opened this issue Mar 23, 2021 · 0 comments

Comments

@VividVisions
Copy link

When I map a result set with a result map where every possible association and collection is defined but the respective columns are missing (not just null), at least one object gets added as association/to the collection anyway, with every property undefined.

Version used: 1.1.2
This worked in older versions because the check there was for a falsy id property which included undefined and now the check uses the identity operator for null.

This should be fixed by also checking for undefined id properties and not just for null ids.

yurii-shchur added a commit to yurii-shchur/joinjs that referenced this issue Nov 26, 2021
when association/collection is not present (archfirst#35)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant