Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of .git folder and .gitignore #82

Closed
samuelmanzanera opened this issue Oct 6, 2022 · 2 comments
Closed

Support of .git folder and .gitignore #82

samuelmanzanera opened this issue Oct 6, 2022 · 2 comments
Assignees
@apoorv-2204
Labels
feature new feature or enhancement

Comments

@samuelmanzanera
Copy link
Member

Is your feature request related to a problem?

If we are deploying in a folder containing .git, the CLI will deploy all the files including .git directory.

Describe the solution you'd like

So to avoid unnecessary uploads, we should exclude .git folder and handle files/folder in .gitignore to avoid mistakes.

Additional context

No response
@samuelmanzanera samuelmanzanera added the feature new feature or enhancement label Oct 6, 2022
@samuelmanzanera samuelmanzanera mentioned this issue Oct 6, 2022
Closed
@internet-zero
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @samuelmanzanera @Neylix @apoorv-2204

@Neylix Neylix changed the title Support of .git folder and .gitgnore Support of .git folder and .gitignore Nov 12, 2022
@herissondev herissondev mentioned this issue Nov 13, 2022
Closed
@apoorv-2204 apoorv-2204 self-assigned this Dec 15, 2022
@apoorv-2204 apoorv-2204 mentioned this issue Dec 15, 2022
Merged
2 tasks
Neylix added a commit that referenced this issue Jan 20, 2023
@apoorv-2204 @herissondev @Neylix
Support of .git folder and .gitignore #82 (#93)
04fded2 
* add ignore and parse-gitignore dependency

* add dependency signore and parse-gitignore

* adding git-folder argument

* handle .gitignore

* check if gitignore exists

* add getAbsolutePath function

* use absolute path function

* change argument name

* change behaviour: default ignore files / alway ignore .git

* Move  function estimateTxsFees

* Support for flag --include-git-folder-files

* support for gitignore

* change var name entry to folderPath

* update libs

* update package to use archethic v1.14

* Refactor git ignore and handle nested gitignore

Co-authored-by: erisson <[email protected]>
Co-authored-by: Neylix <[email protected]>
@Neylix
Copy link
Member

Neylix commented Jan 20, 2023

Closed by #93

@Neylix Neylix closed this as completed Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apoorv-2204 apoorv-2204

Labels
feature new feature or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samuelmanzanera @Neylix @internet-zero @apoorv-2204