Limit the search results to 10000 records & corresponding # of pages #4993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Jul 10, 2019
| @@ -34,7 +34,7 @@ def append_dsl(self, search_results_object, permitted_nodegroups, include_provis | |||
| search_results_object['query'].limit = limit | |||
|
|
|||
| def post_search_hook(self, search_results_object, results, permitted_nodegroups): | |||
| total = results['hits']['total'] | |||
| total = results['hits']['total'] if results['hits']['total'] <= settings.SEARCH_RESULT_LIMIT else settings.SEARCH_RESULT_LIMIT | |||
There was a problem hiding this comment.
E501 line too long (134 > 119 characters)
| @@ -467,6 +467,7 @@ | |||
| SEARCH_DROPDOWN_LENGTH = 100 | |||
| SEARCH_TERM_SENSITIVITY = 3 # a lower number will give more "Fuzzy" matches, recomend between 0-4, see "prefix_length" at https://www.elastic.co/guide/en/elasticsearch/reference/6.7/query-dsl-fuzzy-query.html#_parameters_7 | |||
| WORDS_PER_SEARCH_TERM = 10 # set to None for unlimited number of words allowed for search terms | |||
| SEARCH_RESULT_LIMIT = 10000 # should be less than or equal to elasticsearch configuration, index.max_result_window (default = 10,000) | |||
There was a problem hiding this comment.
E261 at least two spaces before inline comment
E501 line too long (133 > 119 characters)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Limit the search result pagination to match the elastic search results limit (default is 10,000) by adding parameter in settings.py and limiting the total number for pagination to 10,000, re# 4318
paging_filter.py, settings.py
Description of Change
Issues Solved
Now, only 400 pages (the number of pages that corresponds to 10,000 with 25 records per page) are shown in the page selector. The total number of records are still showing the correct total.
Checklist
Ticket Background
Further comments