Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds superuser escape hatch to has_perm #11743 #11744

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

chrabyrd
Copy link
Contributor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

This resolves the issue of has_perm returning False for superusers, as superusers have all permissions including no_access_to_nodegroup

Issues Solved

Closes #11743

Checklist

  • I targeted one of these branches:
    • dev/8.0.x (under development): features, bugfixes not covered below
    • dev/7.6.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

@chrabyrd chrabyrd requested a review from aarongundel January 23, 2025 00:00
Copy link
Contributor

@aarongundel aarongundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarongundel aarongundel self-requested a review January 23, 2025 00:05
Copy link
Contributor

@aarongundel aarongundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrabyrd chrabyrd merged commit 4b44911 into dev/7.6.x Jan 23, 2025
6 of 7 checks passed
@chrabyrd chrabyrd deleted the 11743-cbyrd-has_perm-superuser-escape-hatch branch January 23, 2025 18:10
chiatt added a commit that referenced this pull request Jan 24, 2025
chiatt added a commit that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants