Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ES seems to indicate authoritative edits are provisional #4725

Closed
adamlodge opened this issue Mar 28, 2019 · 4 comments
Closed

bug: ES seems to indicate authoritative edits are provisional #4725

adamlodge opened this issue Mar 28, 2019 · 4 comments
Assignees
Labels
Subject: Search Type: Bug Something isn't working

Comments

@adamlodge
Copy link
Collaborator

I create a new tile (as the admin user) which was captured in the db as authoritative. I verified this by looking at the tile record in pgadmin to see that the tiledata column was populated, and not the provisionaledits column.

When the new resource is displayed in search, it is marked as provisional.

Further, the resource editor recognizes that it is authoritative, so there is no way to change its status.

@adamlodge adamlodge changed the title bug: ES seems to indicate authorotative edits are provisional bug: ES seems to indicate authoritative edits are provisional Mar 29, 2019
@chiatt chiatt self-assigned this Apr 3, 2019
@chiatt chiatt added the Type: Bug Something isn't working label Apr 3, 2019
chiatt added a commit that referenced this issue Apr 3, 2019
chiatt added a commit that referenced this issue Apr 3, 2019
chiatt added a commit that referenced this issue Apr 3, 2019
Deletes a new resource if first attempt to save tile to it fails. re #4725
@chiatt chiatt assigned adamlodge and unassigned chiatt Apr 3, 2019
@adamlodge
Copy link
Collaborator Author

@chiatt Your fix works - mostly. I wouldnt normally think to test this, but I created a valid resource with a single tile. It indexed properly. Then I went back to edit mode and deleted that tile. The resource continues to exist, but is marked provisional in the ui. It seems like any time that a resource instance lacks tiles, it ought to cease to exist. The good news is that at least now i can get back into edit mode in these cases - which i could not do before.

@adamlodge
Copy link
Collaborator Author

@chiatt and I talked. We think the ideal solution is this:
If there is only one tile in an instance, and user tries to delete that tile, then user should be prevented from doing that and given a message saying that this is the only data tile in the resource, and that if you want to delete the resource, then use the delete resource button. This does not preclude user from issuing updates to the sole remaining tile.

@dwuthrich
Copy link
Contributor

dwuthrich commented Apr 4, 2019

@adamlodge @chiatt A slight riff on your proposed solution: when you alert the user with a message, present them with the option to delete the instance in the alert panel (instead of making them close the alert, open the manage menu, and select the delete resource option).

@adamlodge
Copy link
Collaborator Author

Original ticket issue is resolved. I'm gonna close this and open a new one to address the tile-less resource bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Subject: Search Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants