Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grouping_node column to NodeGroup #11613

Open
jacobtylerwalls opened this issue Nov 11, 2024 · 0 comments · May be fixed by #11614
Open

Add grouping_node column to NodeGroup #11613

jacobtylerwalls opened this issue Nov 11, 2024 · 0 comments · May be fixed by #11614
Assignees
@jacobtylerwalls
Labels
Subject: Performance Type: Enhancement

Comments

@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented Nov 11, 2024 •
edited
Loading

It just occurred to me could add a column is_root_node to the Node model ... so that we don't have to run these searches.

Originally posted by @jacobtylerwalls in #11596 (comment)

Noticed while dev'ing #11595 that it would be more convenient to have a database column for the node at the root of a node's nodegroup--and have it be a self-referencing FK that returns Node instances--to avoid having to run a search that gathers siblings nodes and compares them to the nodegroup_id in Python.
@jacobtylerwalls jacobtylerwalls self-assigned this Nov 11, 2024
jacobtylerwalls added a commit that referenced this issue Nov 11, 2024
@jacobtylerwalls
Add Node.nodegroup_root #11613
cb99670
@jacobtylerwalls jacobtylerwalls linked a pull request Nov 11, 2024 that will close this issue
Open
11 tasks
jacobtylerwalls added a commit that referenced this issue Nov 11, 2024
@jacobtylerwalls
Rename migrations re #11613
581c419
jacobtylerwalls added a commit that referenced this issue Nov 11, 2024
@jacobtylerwalls
Reduce drift between setup_db and load_package -db re #11613
b05f1a3
@jacobtylerwalls jacobtylerwalls moved this to 🏗 In Progress in pipeline Nov 12, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In Progress to 👀 In Review in pipeline Nov 12, 2024
jacobtylerwalls added a commit that referenced this issue Nov 12, 2024
@jacobtylerwalls
nit re #11613
0304a86
jacobtylerwalls added a commit that referenced this issue Nov 14, 2024
@jacobtylerwalls
Add constraint that nodegroups match grouping node #11613
2ce4baf
jacobtylerwalls added a commit that referenced this issue Nov 14, 2024
@jacobtylerwalls
Propagate new field to serialized graphs re #11613
41e267e
jacobtylerwalls added a commit that referenced this issue Nov 14, 2024
@jacobtylerwalls
nit re: future graphs re #11613
a9b2f32
jacobtylerwalls added a commit that referenced this issue Nov 14, 2024
@jacobtylerwalls
Sync grouping node id in more cases re #11613
3d76882
@jacobtylerwalls jacobtylerwalls changed the title Add nodegroup_root column to Node Add grouping_node column to Node Nov 14, 2024
@jacobtylerwalls jacobtylerwalls changed the title Add grouping_node column to Node Add grouping_node column to NodeGroup Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
Subject: Performance Type: Enhancement
Projects
pipeline
Status: 👀 In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add NodeGroup.grouping_node #11613 archesproject/arches
1 participant
@jacobtylerwalls