Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With more than 3 arches applications pip install -e ... is not supported #11274

Closed
jacobtylerwalls opened this issue Aug 2, 2024 · 0 comments · Fixed by #11275
Closed

With more than 3 arches applications pip install -e ... is not supported #11274

jacobtylerwalls opened this issue Aug 2, 2024 · 0 comments · Fixed by #11275
Assignees
Labels

Comments

@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented Aug 2, 2024

After #11016, when projects became arches applications also (i.e. "Arches Application" = "anything built with arches"), @chiatt found an issue with these four applications installed, most of them with pip install -e in editable mode:

Currently we only support up to three arches applications for editable installs; any application after the fourth is assumed to exist only in site-packages, the regular pip install location.

The reason for this is that load-component-dependencies.js has two dynamic components: the component name (e.g. report.js) and the arches application name. Webpack supports at most one dynamic component. In other words, it needs to be told where to look, and editable project locations could be anywhere on your filesystem. (You don't want Webpack to crawl your whole system anyway.)

We could explore trying to expose a setting like EDITABLE_PROJECTS_FOLDER and tell webpack to look there, but the quick fix is to just increase the limit from 3 to somewhere around 8 or 9.

@chiatt chiatt added this to pipeline Aug 2, 2024
@jacobtylerwalls jacobtylerwalls self-assigned this Aug 2, 2024
@jacobtylerwalls jacobtylerwalls moved this to 🏗 In Progress in pipeline Aug 2, 2024
@jacobtylerwalls jacobtylerwalls linked a pull request Aug 2, 2024 that will close this issue
11 tasks
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In Progress to 👀 In Review in pipeline Aug 2, 2024
@chiatt chiatt closed this as completed Aug 6, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants