Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "lenient" file-checking mode #10862

Closed
jacobtylerwalls opened this issue May 2, 2024 · 1 comment · Fixed by #10863
Closed

Add "lenient" file-checking mode #10862

jacobtylerwalls opened this issue May 2, 2024 · 1 comment · Fixed by #10863
Assignees
@jacobtylerwalls

Comments

@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented May 2, 2024 •
edited
Loading

validate_file_type() runs some safety checks on uploaded files:

  • determinable file type
  • safe zip file
  • well-formatted xlsx or csv files
  • permitted file type

... but only if FILE_TYPE_CHECKING = True.

Proposal:
@jacobtylerwalls jacobtylerwalls self-assigned this May 2, 2024
@chiatt chiatt added this to pipeline May 2, 2024
jacobtylerwalls added a commit that referenced this issue May 2, 2024
@jacobtylerwalls
Deprecate FILE_TYPE_CHECKING = False #10862
b9f3899
@jacobtylerwalls jacobtylerwalls mentioned this issue May 2, 2024
Merged
6 tasks
jacobtylerwalls added a commit that referenced this issue May 2, 2024
@jacobtylerwalls
Add tip to run project tests re #10862
5020036
jacobtylerwalls added a commit that referenced this issue Jun 14, 2024
@jacobtylerwalls
Add lenient file-type checking mode #10862
bcaae04
jacobtylerwalls added a commit that referenced this issue Jun 14, 2024
@jacobtylerwalls
nit re #10862
56300cc
jacobtylerwalls added a commit that referenced this issue Jun 14, 2024
@jacobtylerwalls
logic nit re #10862
8125407
jacobtylerwalls added a commit that referenced this issue Jun 17, 2024
@jacobtylerwalls
Complete test coverage of file validator #10862
52afd2a
@jacobtylerwalls jacobtylerwalls changed the title Remove FILE_TYPE_CHECKING setting Add "lenient" file-checking mode Jun 17, 2024
@jacobtylerwalls jacobtylerwalls moved this to 👀 In Review in pipeline Jun 17, 2024
jacobtylerwalls added a commit that referenced this issue Jun 18, 2024
@jacobtylerwalls
Use SimpleTestCase re #10862
90557ee
jacobtylerwalls added a commit that referenced this issue Jun 25, 2024
@jacobtylerwalls
Add lenient file-type checking mode #10862
5f25a27
jacobtylerwalls added a commit that referenced this issue Jun 25, 2024
@jacobtylerwalls
nit re #10862
9885c35
jacobtylerwalls added a commit that referenced this issue Jun 25, 2024
@jacobtylerwalls
logic nit re #10862
c329b45
jacobtylerwalls added a commit that referenced this issue Jun 25, 2024
@jacobtylerwalls
Complete test coverage of file validator #10862
96a4e9d
jacobtylerwalls added a commit that referenced this issue Jun 25, 2024
@jacobtylerwalls
Use SimpleTestCase re #10862
bfa9e6f
@jacobtylerwalls jacobtylerwalls linked a pull request Jun 25, 2024 that will close this issue
Add lenient file-type checking mode #10862 #10863
Merged
6 tasks
@jacobtylerwalls
Copy link
Member Author

Fixed in #10863

@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
None yet
Projects
pipeline
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add lenient file-type checking mode #10862 archesproject/arches
1 participant
@jacobtylerwalls