Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph Designer: Deleting Associated Instances should tell you how many were deleted #10781

Closed
whatisgalen opened this issue Apr 17, 2024 · 0 comments · Fixed by #10782
Closed

Graph Designer: Deleting Associated Instances should tell you how many were deleted #10781

whatisgalen opened this issue Apr 17, 2024 · 0 comments · Fixed by #10782
Assignees
@whatisgalen

Comments

@whatisgalen
Copy link
Member

This would be a nice improvement as a sanity check that you deleted the number you thought you would. Ideally it would give you this count in advance, too.
@chiatt chiatt added this to pipeline Apr 17, 2024
whatisgalen added a commit that referenced this issue Apr 17, 2024
@whatisgalen
get count of resourceinstances before deleting, re #10781
7e272f2
whatisgalen added a commit that referenced this issue Apr 17, 2024
@whatisgalen
reports deleted resource count in success message, re #10781
69845af
@whatisgalen whatisgalen mentioned this issue Apr 17, 2024
Merged
6 tasks
whatisgalen added a commit that referenced this issue Apr 17, 2024
@whatisgalen
returns deleted_count from graph.delete_instances(), renames var, re #…
c8b2fcf 
…10781
whatisgalen added a commit that referenced this issue Apr 18, 2024
@whatisgalen
re-orgs into single query, assigns bar count to delete_count, rm incr…
4e2c3b5 
…ement operation, re #10781
whatisgalen added a commit that referenced this issue Apr 18, 2024
@whatisgalen
rm unnecessary print statement; bar.update already prints, re #10781
edc63d4
@jacobtylerwalls jacobtylerwalls moved this to 👀 In Review in pipeline Apr 18, 2024
whatisgalen added a commit that referenced this issue Apr 18, 2024
@whatisgalen
Revert "rm unnecessary print statement; bar.update already prints, re #…
11b692d 
…10781"

This reverts commit edc63d4.
whatisgalen added a commit that referenced this issue Apr 18, 2024
@whatisgalen
includes request in kwargs for graph.delete_instances, re #10781
37fee10
whatisgalen added a commit that referenced this issue Apr 18, 2024
@whatisgalen
leverages BulkDataDeletion module to delete and index graph resources…
c640753 
…, re #10781
whatisgalen added a commit that referenced this issue Apr 18, 2024
@whatisgalen
passes request to graph.delete_instances, defines returned response, re
8582c3a 
#10781
whatisgalen added a commit that referenced this issue Apr 18, 2024
@whatisgalen
includes addtnl kwarg on result response in bulk delete_resources to …
5461c9a 
…include deleted_count; uses to define message, re #10781
whatisgalen added a commit that referenced this issue Apr 18, 2024
@whatisgalen
passes returned response from bulk_deleter to graph view from graph.d…
292ab2d 
…elete_instances, re #10781
whatisgalen added a commit that referenced this issue Apr 18, 2024
@whatisgalen
changes graph.delete_instances(request) to pos arg, re #10781
2f1c486
whatisgalen added a commit that referenced this issue Apr 18, 2024
@whatisgalen
puts bulk_deleter delete_resources user lookup in try/except for no u…
6179141 
…serid supplied, re #10781
whatisgalen added a commit that referenced this issue Apr 18, 2024
@whatisgalen
changes request to userid kwarg, optional, re #10781
45b905a
whatisgalen added a commit that referenced this issue Apr 18, 2024
@whatisgalen
fix for python3.11 f string compat issue, re #10781
be4bcfb
whatisgalen added a commit that referenced this issue Apr 19, 2024
@whatisgalen
adds verbose kwarg and logic to bulk_deleter delete_resources(), re #…
81198ff 
…10781
whatisgalen added a commit that referenced this issue Apr 19, 2024
@whatisgalen
passes verbose kwarg from graph.delete_instances() to bulk_deleter.de…
29141f8 
…lete_resources(), re #10781
whatisgalen added a commit that referenced this issue Apr 19, 2024
@whatisgalen
rm redundant var, re #10781
be62675
whatisgalen added a commit that referenced this issue Apr 22, 2024
@whatisgalen
replace deleted_ct incrementor with .count query, re #10781
5c139d7
whatisgalen added a commit that referenced this issue Apr 22, 2024
@whatisgalen
replace try except for userid=None with if else, re #10781
fdc9ef2
whatisgalen added a commit that referenced this issue Apr 22, 2024
@whatisgalen
fixes gettext success msg for bulk_data.delete_resources, re #10781
6ca9936
whatisgalen added a commit that referenced this issue Apr 22, 2024
@whatisgalen
moves import statement of bulkdeleter from method to file header, re #…
e2acf97 
…10781
whatisgalen added a commit that referenced this issue Apr 22, 2024
@whatisgalen
adds line in changelog for 7.6.0 re #10781
170a2e0
@jacobtylerwalls jacobtylerwalls linked a pull request Apr 22, 2024 that will close this issue
10781 Directs graph.delete_instances to call bulk_delete methods #10782
Merged
6 tasks
whatisgalen added a commit that referenced this issue Apr 28, 2024
@whatisgalen
fixes merge conflict in release file for 7.6, re #10781
16f941d
whatisgalen added a commit that referenced this issue Apr 28, 2024
@whatisgalen
reverts signature default val for userid in delete_instances() for no…
00399b8 
…w, re #10781
whatisgalen added a commit that referenced this issue Apr 29, 2024
@whatisgalen
Revert "reverts signature default val for userid in delete_instances(…
8f88583 
…) for now, re #10781"

This reverts commit 00399b8.

make userid default assignment elsewhere until core issue fixed
whatisgalen added a commit that referenced this issue Apr 29, 2024
@whatisgalen
conforms to current pattern of user defaulting to empty dict, re #10781
8effe61
whatisgalen added a commit that referenced this issue Apr 29, 2024
@whatisgalen
passes in empty list for pos arg resourceids, re #10781
d1ede61
whatisgalen added a commit that referenced this issue Apr 29, 2024
@whatisgalen
changes dummy pos arg for resourceids to None, re #10781
4e65fe5
whatisgalen added a commit that referenced this issue Apr 30, 2024
@whatisgalen
creates 3 basic tests for bulkdatadeletion, re #10781
cca046d
whatisgalen added a commit that referenced this issue Apr 30, 2024
@whatisgalen
includes commented command to run test locally, re #10781
71d2fea
whatisgalen added a commit that referenced this issue May 1, 2024
@whatisgalen
turns bulkdata tests into module, re #10781
5356a83
whatisgalen added a commit that referenced this issue May 2, 2024
@whatisgalen
cleanup tests for bulk_delete, re #10781
2cbbf2d
whatisgalen added a commit that referenced this issue May 2, 2024
@whatisgalen
comments test that cannot work right now, re #10781 and #10858
3b27571
whatisgalen added a commit that referenced this issue May 2, 2024
@whatisgalen
refactors bulk_deleter.delete_resources signature to make graphid, re…
4df4638 
…sourceids kwargs with default None, re #10781
whatisgalen added a commit that referenced this issue May 2, 2024
@whatisgalen
returns unsuccessful delete message if neither graphid nor resourceid…
1b3e6ac 
…s provided to bulk delete_resources, re #10781
whatisgalen added a commit that referenced this issue May 2, 2024
@whatisgalen
refactors usage of delete_resources to conform to graphid, resourceid…
678e82c 
…s as kwargs, re #10781
whatisgalen added a commit that referenced this issue May 2, 2024
@whatisgalen
fix imports, re #10781
3f45e75
whatisgalen added a commit that referenced this issue May 2, 2024
@whatisgalen
more test cleanup, re #10781
b208fe3
whatisgalen added a commit that referenced this issue May 2, 2024
@whatisgalen
fixes mis-import, re #10781
c2b876a
whatisgalen added a commit that referenced this issue May 2, 2024
@whatisgalen
fixes graph import issue in test, re #10781
4082bb0
whatisgalen added a commit that referenced this issue May 2, 2024
@whatisgalen
rm uneeded tearDown method, re #10781
3abd5ee
jacobtylerwalls added a commit that referenced this issue May 2, 2024
@jacobtylerwalls
Remove unused imports re #10781
486fb04
jacobtylerwalls added a commit that referenced this issue May 2, 2024
@jacobtylerwalls
Add breaking change notice re #10781
9a7f83c
whatisgalen added a commit that referenced this issue May 3, 2024
@whatisgalen
changes pos arg resourceids in bulk.index_resource_deletion to kwarg …
9bbdaf5 
…with None default; refactors usage, re #10781
whatisgalen added a commit that referenced this issue May 3, 2024
@whatisgalen
simplify control flow for bulk_delete.delete_resources, re #10781
67e4c18
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whatisgalen whatisgalen

Labels
None yet
Projects
pipeline
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

10781 Directs graph.delete_instances to call bulk_delete methods archesproject/arches
2 participants
@whatisgalen @jacobtylerwalls