Scheme report rough out #115

aarongundel · 2024-11-04T23:20:52Z

Initial attempt on roughing out scheme report

chrabyrd

Are you able to clean up this PR? There seems to be some leakage from Jacob's work. I'm fine if this is based off of that branch

aarongundel · 2024-11-05T22:31:38Z

rebased to merge into Jacob's branch.

chrabyrd

Good rough out! Just a few notes 👍

chrabyrd · 2024-11-15T18:23:26Z

arches_lingo/src/arches_lingo/components/scheme/report/SchemeSection.vue

+    titleText: string;
+}>();
+
+const buttonText = `Add ${props.titleText}`;


needs i18n, also if it's just display text it should be inlined

chrabyrd · 2024-11-15T18:24:29Z

arches_lingo/src/arches_lingo/components/scheme/report/SchemeSection.vue

+
+<style scoped>
+.section {
+    margin: 0 20px;


for Vue development we're moving away from sizing via px, and instead using rem to better support accessibility and smaller screens 👍

chrabyrd · 2024-11-15T18:26:38Z

arches_lingo/src/arches_lingo/pages/SchemeReport.vue

+import SchemeUri from "@/arches_lingo/components/scheme/report/SchemeUri.vue";
+import SchemeStandard from "@/arches_lingo/components/scheme/report/SchemeStandard.vue";
+import SchemeAuthority from "@/arches_lingo/components/scheme/report/SchemeAuthority.vue";
+import Splitter from "primevue/splitter";


nit: vue/primevue imports above arches imports

chrabyrd · 2024-11-15T18:27:08Z

arches_lingo/src/arches_lingo/components/scheme/report/SchemeUri.vue

@@ -0,0 +1,7 @@
+<script setup lang="ts">
+import SchemeReportSection from "./SchemeSection.vue";


all imports should use the @/path pattern

arches_lingo/src/arches_lingo/types.ts

chrabyrd · 2024-11-15T19:21:09Z

arches_lingo/src/arches_lingo/components/scheme/report/SchemeSection.vue

I like the idea of this component, but it may need to go away in further iterations as cardinality logic with these section components may prove tricky

aarongundel · 2024-11-18T19:14:13Z

Great feedback, thanks!

chrabyrd

looks good! Just a few more things have fallen out 👍

chrabyrd · 2024-11-21T20:31:54Z

arches_lingo/src/arches_lingo/components/scheme/report/SchemeSection.vue

+    titleText: string;
+}>();
+
+const buttonText = $gettext(`Add ${props.titleText}`);


gettext interpolation needs to be updated

https://jshmrtn.github.io/vue3-gettext/functions.html#interpolation

Also IMO you should inline this instead of declaring it.

chrabyrd · 2024-11-21T20:33:29Z

arches_lingo/src/arches_lingo/components/scheme/report/SchemeSection.vue

+.section .header {
+    display: flex;
+    align-items: center;
+    border-bottom: 1px solid #ddd;


IMO this should change to reusable var: var(--p-menubar-border-color);

arches_lingo/src/arches_lingo/pages/SchemeReport.vue

chrabyrd · 2024-11-21T20:36:08Z

arches_lingo/src/arches_lingo/pages/SchemeReport.vue

+    <div>
+        <Splitter>
+            <SplitterPanel>
+                <SchemeNote />


nit: these don't need to be hardcoded, they can be used in a v-for loop like SideNav items

I will punt on this until the adg/125-namespace-scheme PR where this is done.

chrabyrd · 2024-11-21T20:37:52Z

arches_lingo/src/arches_lingo/pages/SchemeReport.vue

need flexbox css for this, I'd expect the page component to take up 100% of the available width/height, and be scrollable without losing the topnav:

The more I look at this, the more I think this is a change for App.vue rather than the scheme report itself.

cool, fair 👍

arches_lingo/src/arches_lingo/components/scheme/report/SchemeSection.vue

chrabyrd

looks good! One minor thing with the splitter and it should be g2g 🎉

arches_lingo/src/arches_lingo/pages/SchemePage.vue

chrabyrd · 2024-12-03T20:00:12Z

arches_lingo/src/arches_lingo/pages/SchemeReport.vue

cool, fair 👍

chrabyrd

lgtm! 🚀

aarongundel requested a review from chrabyrd November 4, 2024 23:20

aarongundel assigned chrabyrd Nov 4, 2024

aarongundel linked an issue Nov 5, 2024 that may be closed by this pull request

rough out scheme report section #98

Closed

chrabyrd requested changes Nov 5, 2024

View reviewed changes

aarongundel changed the base branch from main to jtw/new-tree-front-end November 5, 2024 22:31

aarongundel requested a review from chrabyrd November 5, 2024 22:31

aarongundel changed the base branch from jtw/new-tree-front-end to jtw/prototype-serializers November 12, 2024 18:28

chrabyrd requested changes Nov 15, 2024

View reviewed changes

aarongundel requested a review from chrabyrd November 18, 2024 19:14

Base automatically changed from jtw/prototype-serializers to jtw/new-tree-front-end November 20, 2024 18:49

jacobtylerwalls force-pushed the jtw/new-tree-front-end branch from 09c1a24 to b82dfa0 Compare November 20, 2024 19:26

aarongundel force-pushed the adg/scheme-report branch 2 times, most recently from 2a278d9 to 874b141 Compare November 21, 2024 16:44

chrabyrd requested changes Nov 21, 2024

View reviewed changes

aarongundel requested a review from chrabyrd December 2, 2024 22:20

jacobtylerwalls force-pushed the jtw/new-tree-front-end branch from e65f279 to 403ab8d Compare December 3, 2024 15:50

jacobtylerwalls reviewed Dec 3, 2024

View reviewed changes

arches_lingo/src/arches_lingo/components/scheme/report/SchemeSection.vue Outdated Show resolved Hide resolved

aarongundel force-pushed the adg/scheme-report branch 2 times, most recently from 9605a1a to f9695ac Compare December 3, 2024 17:18

chrabyrd requested changes Dec 3, 2024

View reviewed changes

chrabyrd approved these changes Dec 3, 2024

View reviewed changes

jacobtylerwalls force-pushed the jtw/new-tree-front-end branch from 6253eb9 to 7e0d0c8 Compare December 3, 2024 21:45

Base automatically changed from jtw/new-tree-front-end to main December 3, 2024 21:57

aarongundel added 4 commits December 3, 2024 15:51

Updates for scheme report

1c00aaa

updates with components for individual sections

3a0fbb6

update page names to conform to patterns, pr feedback

6174df5

reduce h2 to h3 for section headers (page header is h2)

dc9c36f

aarongundel force-pushed the adg/scheme-report branch from d5280ed to dc9c36f Compare December 3, 2024 22:51

aarongundel merged commit f924b87 into main Dec 3, 2024
5 of 6 checks passed

aarongundel deleted the adg/scheme-report branch December 3, 2024 22:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scheme report rough out #115

Scheme report rough out #115

aarongundel commented Nov 4, 2024 •

edited

Loading

chrabyrd left a comment

aarongundel commented Nov 5, 2024

chrabyrd left a comment

chrabyrd Nov 15, 2024

chrabyrd Nov 15, 2024

chrabyrd Nov 15, 2024

chrabyrd Nov 15, 2024

chrabyrd Nov 15, 2024

aarongundel commented Nov 18, 2024

chrabyrd left a comment

chrabyrd Nov 21, 2024

chrabyrd Nov 21, 2024

chrabyrd Nov 21, 2024

aarongundel Nov 22, 2024

chrabyrd Nov 21, 2024

aarongundel Dec 2, 2024

chrabyrd Dec 3, 2024

chrabyrd left a comment

chrabyrd Dec 3, 2024

chrabyrd left a comment

		@@ -0,0 +1,7 @@
		<script setup lang="ts">
		import SchemeReportSection from "./SchemeSection.vue";

Scheme report rough out #115

Scheme report rough out #115

Conversation

aarongundel commented Nov 4, 2024 • edited Loading

chrabyrd left a comment

Choose a reason for hiding this comment

aarongundel commented Nov 5, 2024

chrabyrd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aarongundel commented Nov 18, 2024

chrabyrd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrabyrd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrabyrd left a comment

Choose a reason for hiding this comment

aarongundel commented Nov 4, 2024 •

edited

Loading