-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add python formatting proposal #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve.
Not marking an official approval since I am a core member of the Pbench repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems fine to me.
Seems fine to me |
I agree with the idea, but I would like the formatting requirements explicitly documented. "Whatever is in this file" isn't going to help a newcomer reading this decision understand the requirements. Please explicitly inline the requirements in the decision. |
@janosdebugs, see #18, I did not push it to that branch since it was @dustinblack's proposal. |
art-decisions/proposals/2022-10-26-standardize-python-formatting.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please review @jaredoconnell comment
6625b8f
to
645bda6
Compare
645bda6
to
c1196e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes introduced with this PR
Adding a proposal to standardize on one python code formatting solution.
By contributing to this repository, I agree to the contribution guidelines.