Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python formatting proposal #16

Merged
merged 6 commits into from
Nov 4, 2022
Merged

add python formatting proposal #16

merged 6 commits into from
Nov 4, 2022

Conversation

dustinblack
Copy link
Member

Changes introduced with this PR

Adding a proposal to standardize on one python code formatting solution.


By contributing to this repository, I agree to the contribution guidelines.

Copy link
Contributor

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

Not marking an official approval since I am a core member of the Pbench repository.

Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems fine to me.

@jdowni000
Copy link
Contributor

Seems fine to me

@ghost
Copy link

ghost commented Oct 27, 2022

I agree with the idea, but I would like the formatting requirements explicitly documented. "Whatever is in this file" isn't going to help a newcomer reading this decision understand the requirements. Please explicitly inline the requirements in the decision.

@portante
Copy link
Contributor

@janosdebugs, see #18, I did not push it to that branch since it was @dustinblack's proposal.

@dustinblack dustinblack requested a review from a team October 28, 2022 16:35
Copy link
Contributor

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review @jaredoconnell comment

Copy link
Contributor

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustinblack dustinblack merged commit e3a4f7e into main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants