Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment describing meaning of context cancelled #6

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Update comment describing meaning of context cancelled #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions interface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ type Connector interface {
//
// Parameters:
// ctx: The context that lasts the length of the deployment.
// Cancelling the context will send a SIGTERM request to terminate the deployment,
// which can be used to cancel the running step.
// A cancelled context means the plugin is in the process of getting shut down, or is shut down. No new
// deployment should be allowed.
// pluginSource: The source of the plugin. This can be the tag of the image to run, a Python module, or
// anything else that the deployer supports.
Deploy(ctx context.Context, pluginSource string) (Plugin, error)
Expand Down