-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace inline calls for <meta> and styles with single php include #6
Comments
Note: page-specific styles and JS will still be called at the page level, and will not be embedded in the style call file for obvious reasons. |
Closed by 17e44a7. Created
Replaced these (and variations...):
With this:
And after with this:
|
Plan has changed in coordination with Ed, since Example in [this commit]: BioKIC@71d6ae2 |
Skipped `collections/reports/labels.php`. Works on #6
Templating is done manually in this framework, by including header and footer files in each content page.
Content pages have their own
html
,meta
, andbody
tags.That means that a lot of the head content is repeated, and if one would like to change styles radically, it would be tedious and laborious to manually replace each single call in the over 100 pages in this codebase.
Thus, each file will now include a call to a styles configuration php file, that will then include the general style calls and appropriate
meta
tags, such as the ones important for mobile responsiveness and accessibility.This is a somewhat long task.
The text was updated successfully, but these errors were encountered: