Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch workflow by project id #84

Closed
wants to merge 7 commits into from
Closed

Conversation

ReiHashimoto
Copy link

@ReiHashimoto ReiHashimoto commented May 16, 2023

optinistの以下のPRと同様の対応

oist#494


実行時に以下のエラーも出ていたため、追加でrequirements.txtを更新

$ python main.py
Traceback (most recent call last):
  File "main.py", line 9, in <module>
    from optinist.__main_unit__ import main
  File "/Users/rei_hashimoto/GitHub/MRIAnalysisStudioforMouse/optinist/__main_unit__.py", line 13, in <module>
    from backend.routers import auth, user_manage
  File "/Users/rei_hashimoto/GitHub/MRIAnalysisStudioforMouse/backend/routers/auth.py", line 3, in <module>
    from backend.deps import get_current_user
  File "/Users/rei_hashimoto/GitHub/MRIAnalysisStudioforMouse/backend/deps.py", line 5, in <module>
    from backend.service.firebase.crud_user import read_user
  File "/Users/rei_hashimoto/GitHub/MRIAnalysisStudioforMouse/backend/service/firebase/__init__.py", line 3, in <module>
    import pyrebase
  File "/Users/rei_hashimoto/anaconda3/envs/mri_dev/lib/python3.8/site-packages/pyrebase/__init__.py", line 1, in <module>
    from .pyrebase import initialize_app
  File "/Users/rei_hashimoto/anaconda3/envs/mri_dev/lib/python3.8/site-packages/pyrebase/pyrebase.py", line 20, in <module>
    from requests_toolbelt.adapters import appengine
  File "/Users/rei_hashimoto/anaconda3/envs/mri_dev/lib/python3.8/site-packages/requests_toolbelt/adapters/appengine.py", line 42, in <module>
    from .._compat import gaecontrib
ImportError: cannot import name 'gaecontrib' from 'requests_toolbelt._compat' (/Users/rei_hashimoto/anaconda3/envs/mri_dev/lib/python3.8/site-packages/requests_toolbelt/_compat.py)

@ReiHashimoto ReiHashimoto changed the title 最終実行ワークフローセッションの維持 Keep last workflow session data May 16, 2023
@ReiHashimoto
Copy link
Author

projectごとのworkflow data保持に対応

@ReiHashimoto
Copy link
Author

@itutu-tienday

  • 複数プロジェクトごとのデータ保持
  • プロジェクトを切り替えた際に選択したproject idへのfetch

に対応しました。

以下のコミットは動作確認のためにInputNodeを一時的に使用可能にしたものなので、mergeの前にはrevertします。

@ReiHashimoto ReiHashimoto changed the title Keep last workflow session data Switch workflow by project id May 17, 2023
@itutu-tienday
Copy link
Collaborator

@ReiHashimoto
5/18のバージョンで、動作確認を行いました。
テストケース等、以下に記載しています。
https://drive.google.com/file/d/1_wRbbKPt11vQFlbUyn-NZv6fEShxJenb/

基本的には、想定通りの内容で、動作しているものと思います。
幾つか気づいた点を上記資料に記載していますので、ご確認ください。

@ReiHashimoto
Copy link
Author

merge煩雑になるのでrebaseした以下のPRで対応

@ReiHashimoto ReiHashimoto deleted the keep-last-session branch May 22, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflowセッションの自動復元 Workflowセッションの管理方式の改修
2 participants