Backport/update to 3.0.0/stable3.0 #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we run the update of Workspace to 3.0.X, the migration is stopped and the program doesn't change the display name of Workspace's groups. Why ? Because, when we use the "search" function from "IGroupManager", by default, in addition to groups beginning with "SPACE-GE" or "SPACE-U", we get the guest virtual group. So, the solution is to use the "array_filter" to ignore the "OCA\\Guests\\GroupBackend" backendname. Signed-off-by: Baptiste Fotia <[email protected]>
Signed-off-by: Baptiste Fotia <[email protected]>
This commit could repair the migration when someone updated workspace to v3.0.0 or v3.0.1. Signed-off-by: Baptiste Fotia <[email protected]>
Signed-off-by: Baptiste Fotia <[email protected]>
I added the "=== false" in the condionnal to skip the algorithm if the workspace's version is between 3.0.0 and 3.0.1. Signed-off-by: Baptiste Fotia <[email protected]>
I used the version_compare function to compare 2 differents versions. Signed-off-by: Baptiste Fotia <[email protected]>
I improve the checking of version with the "version_compare" function internal to PHP. Signed-off-by: Baptiste Fotia <[email protected]>
I changed the conditionnal to stop the migration. Signed-off-by: Baptiste Fotia <[email protected]>
Signed-off-by: Baptiste Fotia <[email protected]>
We check if the version installed is less than 3.0.0 to avoid 2 upgrades. Signed-off-by: Baptiste Fotia <[email protected]>
Now, we can fix all the display names from the groups. It works for the Workspace updated to 3.0.0 or 3.0.1. Signed-off-by: Baptiste Fotia <[email protected]>
Signed-off-by: Baptiste Fotia <[email protected]>
Signed-off-by: Baptiste Fotia <[email protected]>
zak39
added
backend
Signed-off-by: Baptiste Fotia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a backport from this PR #843 for the stable3.0 branch