Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide modal window menu when there is an error message #839

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

acdmft
Copy link
Collaborator

@acdmft acdmft commented May 29, 2023

This PR is intended to fix a minor bug of the UI: wWhen trying to rename a user group and there is an error message the modal window continue to be present on the page. This is fixed with adding ref to corresponding component and then call 'this.$refs.ncAction.opened=false'.

This PR is intended to fix a minor bug of the UI: wWhen trying to rename a user group and there is an error message
the modal window continue to be present on the page. This is fixed with adding ref to corresponding component and then call 'this.$refs.ncAction.opened=false'.
@acdmft acdmft added frontend Modification related to frontend minor bug Should be treated after Major and Important bugs labels May 29, 2023
@acdmft acdmft requested a review from zak39 May 29, 2023 09:24
@acdmft acdmft self-assigned this May 29, 2023
@zak39
Copy link
Collaborator

zak39 commented May 29, 2023

It's okay for me :)

@acdmft Can you add this PR in the changelog file from the Unrelease section ?

I think you can create a sub-section in the "Unrelease" that is "Added".

@zak39 zak39 merged commit a2061d0 into main Aug 2, 2023
@zak39 zak39 deleted the fix/hide-menu-on-group-rename branch August 2, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Modification related to frontend minor bug Should be treated after Major and Important bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants