Refactor/convert groupfolders #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I decommented the route to convert a groupfolder to a workspace. Signed-off-by: Baptiste Fotia <[email protected]>
I removed groups from advanced permisions when we convert a groupfolder to a workspace. I took the opportunity to remove some unnecessary code. Signed-off-by: Baptiste Fotia <[email protected]>
zak39
added
backend
I created the new transfertUsersToUserGroup() method to transfer the users to U-<id>. One more, I splited code snippets into several files to simplefy the functions and make it easier to read. Signed-off-by: Baptiste Fotia <[email protected]>
I corrected the spelling mistake "transfert" to "transfert". Signed-off-by: Baptiste Fotia <[email protected]>
I refactored the code to transfer users into User group (U-<id>) and I created a new feature to import the users into Space Manager groups. Signed-off-by: Baptiste Fotia <[email protected]>
Don't check if a group has a spaceId as suffix (ex: DRH-2 or Foo-3). But, can delete the "Bar" group, for example. Signed-off-by: Baptiste Fotia <[email protected]>
I created a new service to get all group manager type. Signed-off-by: Baptiste Fotia <[email protected]>
I translated the feature to convert all groupfolders into workspaces. Signed-off-by: Baptiste Fotia <[email protected]>
I tested the transferUsersToUserGroup function : - if the return of the function is object type - if the return is not undefined Signed-off-by: Baptiste Fotia <[email protected]>
Signed-off-by: Baptiste Fotia <[email protected]>
We can rename a group imported via converting without problem. Signed-off-by: Baptiste Fotia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decommented the route to convert a groupfolder to a workspace.
I removed groups from advanced permisions when we convert a groupfolder to a workspace.
I took the opportunity to remove some unnecessary code.