Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the blank into the start or end when creating space #517

Merged
merged 9 commits into from
Jun 29, 2022

Conversation

zak39
Copy link
Collaborator

@zak39 zak39 commented Jun 24, 2022

When we created a workspace with a blank into the start or end its name. We cannot change the ACLs in advanced permissions.

Before

pb-advanced-permissons-with-blank

After

Create

create-parse-blank-spacename

Rename

rename-parse-blank-spacename

@dorianne-arawa Can you confirm me if it's okay ?

You can watch the demos of the gifs

@zak39 zak39 added backend Modification related to backend debug Ongoing correction labels Jun 24, 2022
@zak39 zak39 requested a review from dorianne-arawa June 24, 2022 15:33
@zak39 zak39 self-assigned this Jun 24, 2022
@dorianne-arawa
Copy link
Collaborator

I prefer without the error message. The Workspace should be created, without the spaces.
@zak39

@zak39 zak39 merged commit d139740 into main Jun 29, 2022
@zak39 zak39 deleted the fix/error-define-in-advanced-permissions branch June 30, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Modification related to backend debug Ongoing correction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants