Fix/translating error msg creating space/421 #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to have a button 'Settings & Import / Convert' and select the groupfolders to import / convert. The SelectGroupfolders component is created to be in a modal and select the groupfolders to convert / import
…r from the store With the groupfolders var from the store, I will print in the SelectGroupfolders modal
Fill the groupfolders list in SelectGroupfolders list when the general manager open the modal. Then, empty this list when the general manager close this modal window
We can convert / import a groupfolder in space and sort automatically
I had to change the data structure for the sorting. Now, the keys of data structure is the mount_point and not the folderId for state.groupfolders
I had to change the function to convert a groupfolder in space of the Front and Back side. Now, when I select one or more groupfolders, they are converted in spaces. Todo: Take users present in the groups into account
When we add a groupfolder with users exists from groups, they will be adding to space with theirs (sub)groups exists and user group
When I translated it, the translating took all width.
After import the groupfolders, the counter users didn't increase. It's fixed now.
When I added a groupfolders to convert in space. It displayed all subgroups. But not users for each subgroups. So, I renamed the 'users' var which erased another var which has the same name. To differentitate, I renamed the 'users' var by 'usersOfAGroup' which contains the IUser list
I had an issue on the build to accept the PR
I think I repaire the build npm side.... To test
I should use this rule : 'vue/first-attribute-linebreak'. I tried config it but it doesn't work... I should search how to work it
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
There is an error in the CI where it doesn't find webpack : ' [webpack-cli] Error: Cannot find module 'webpack''
…r vue-loader vue-template-compiler
…elint-config-recommended-vue
…nded-scss stylelint-scss
I don't need this config file, I use jest now #413 (comment)
The idea is to have a button 'Settings & Import / Convert' and select the groupfolders to import / convert. The SelectGroupfolders component is created to be in a modal and select the groupfolders to convert / import
…r from the store With the groupfolders var from the store, I will print in the SelectGroupfolders modal
Fill the groupfolders list in SelectGroupfolders list when the general manager open the modal. Then, empty this list when the general manager close this modal window
We can convert / import a groupfolder in space and sort automatically
I had to change the data structure for the sorting. Now, the keys of data structure is the mount_point and not the folderId for state.groupfolders
I had to change the function to convert a groupfolder in space of the Front and Back side. Now, when I select one or more groupfolders, they are converted in spaces. Todo: Take users present in the groups into account
When we add a groupfolder with users exists from groups, they will be adding to space with theirs (sub)groups exists and user group
When I translated it, the translating took all width.
After import the groupfolders, the counter users didn't increase. It's fixed now.
When I added a groupfolders to convert in space. It displayed all subgroups. But not users for each subgroups. So, I renamed the 'users' var which erased another var which has the same name. To differentitate, I renamed the 'users' var by 'usersOfAGroup' which contains the IUser list
I had an issue on the build to accept the PR
I think I repaire the build npm side.... To test
I should use this rule : 'vue/first-attribute-linebreak'. I tried config it but it doesn't work... I should search how to work it
I created 2 tests on the converting groupfolders to space
When we input a workspace name similary to a workspace existing, this new error message is trigger : - title: Error - This workspace name already exists - message: Please enter a new workspace name. Please note that workspace names are not case sensitive (france and FRANCE are considered the same workspace name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we input a workspace name similary to a workspace existing, this new error message is trigger :
title: Error - This workspace name already exists
message: Please enter a new workspace name. Please note that workspace names are not case sensitive (france and FRANCE are considered the same workspace name)
Resolve this issue: #421
Demo