Tests/modes #88
Tests/modes #88
Conversation
ObiWahn
force-pushed
the
tests/modes
branch
3 times, most recently
from
1fd689d to
5db8006
Compare
tests/modes_test.go
Outdated
| // check environment | ||
| longOrSkip(t) | ||
|
|
||
| // FIXME - add code |
tests/modes_test.go
Outdated
| @@ -0,0 +1,108 @@ | |||
| // | |||
There was a problem hiding this comment.
I'm confused by the filename.
This is about environments, not modes.
tests/modes_test.go
Outdated
| subTest(t, api.DeploymentModeCluster, api.StorageEngineRocksDB) | ||
| } | ||
|
|
||
| func subTest(t *testing.T, mode api.DeploymentMode, engine api.StorageEngine) error { |
There was a problem hiding this comment.
Please use a more descriptive function name
subTest can apply to any test
tests/modes_test.go
Outdated
| deploymentTemplate.Spec.Environment = api.NewEnvironment(api.EnvironmentProduction) | ||
| deploymentTemplate.Spec.SetDefaults(deploymentTemplate.GetName()) // this must be last | ||
|
|
||
| var dbserverCount int = *deploymentTemplate.Spec.DBServers.Count |
There was a problem hiding this comment.
go: dbserverCount := *deploymentTemplate.Spec.DBServers.Count
tests/modes_test.go
Outdated
|
|
||
| numNodes := len((*nodeList).Items) | ||
|
|
||
| var failExpected bool = false |
tests/modes_test.go
Outdated
| t.Fatalf("Unable to receive node list: %v", err) | ||
| } | ||
|
|
||
| numNodes := len((*nodeList).Items) |
There was a problem hiding this comment.
go: numNodes := len(nodeList.Items)
. will de-reference on its own.
tests/modes_test.go
Outdated
| } | ||
|
|
||
| // Create deployment | ||
| deployment, err := deploymentClient.DatabaseV1alpha().ArangoDeployments(k8sNameSpace).Create(deploymentTemplate) |
There was a problem hiding this comment.
deployment is never used, so you can replace this with
if _, err := deploymentClient.DatabaseV1alpha().ArangoDeployments(k8sNameSpace).Create(deploymentTemplate); err != nil { ...
tests/modes_test.go
Outdated
| t.Fatalf("Create deployment failed: %v", err) | ||
| } | ||
|
|
||
| deployment, err = waitUntilDeployment(deploymentClient, deploymentTemplate.GetName(), k8sNameSpace, deploymentIsReady()) |
There was a problem hiding this comment.
After above change, this will be the first use of deployment, so deployment, err := ...
tests/modes_test.go
Outdated
| deploymentTemplate.Spec.StorageEngine = api.NewStorageEngine(engine) | ||
| deploymentTemplate.Spec.TLS = api.TLSSpec{} // should auto-generate cert | ||
| deploymentTemplate.Spec.Environment = api.NewEnvironment(api.EnvironmentProduction) | ||
| deploymentTemplate.Spec.SetDefaults(deploymentTemplate.GetName()) // this must be last |
There was a problem hiding this comment.
I expected the spec to set Count values above the number of nodes.
That way we can also test what happens when you have a 3 node cluster with 4 dbservers/agents/coordinators.
tests/modes_test.go
Outdated
| deploymentTemplate.Spec.Mode = api.NewMode(mode) | ||
| deploymentTemplate.Spec.StorageEngine = api.NewStorageEngine(engine) | ||
| deploymentTemplate.Spec.TLS = api.TLSSpec{} // should auto-generate cert | ||
| deploymentTemplate.Spec.Environment = api.NewEnvironment(api.EnvironmentProduction) |
There was a problem hiding this comment.
You must specify an Image in production mode.
Added validation of spec to ensure that is all good. [ci LONG=1] [ci TESTOPTIONS="-test.run ^TestProduction$"]
|
Couple of go issues remain, but let's merge it now. |
[ci LONG=1] [ci TESTOPTIONS="-test.run ^TestProduction$"]
ghost
mentioned this pull request
Test if deployments work in development and production mode