Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeSelector #311

Merged
merged 3 commits into from
Dec 5, 2018
Merged

NodeSelector #311

merged 3 commits into from
Dec 5, 2018

Conversation

maierlars
Copy link
Collaborator

@maierlars maierlars commented Dec 4, 2018 •
edited
Loading

Added nodeSelector field that is forwarded to the created pods of the specific group.

@maierlars maierlars added the 9 WIP label Dec 4, 2018
@maierlars maierlars self-assigned this Dec 4, 2018
@maierlars maierlars requested a review from neunhoef December 4, 2018 15:14
@ghost ghost added the 2 - Working label Dec 4, 2018
@maierlars maierlars removed the 9 WIP label Dec 5, 2018
neunhoef
neunhoef approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost assigned neunhoef Dec 5, 2018
@neunhoef neunhoef merged commit 9d87eab into master Dec 5, 2018
@ghost ghost removed the 2 - Working label Dec 5, 2018
@neunhoef neunhoef deleted the feature/node-selector branch December 5, 2018 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees

@neunhoef neunhoef

@maierlars maierlars

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maierlars @neunhoef