[Feature] Scheduler BatchJob Integration Definition #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwierzbo
approved these changes
Mar 26, 2024
neunhoef
reviewed
Mar 27, 2024
There was a problem hiding this comment.
This looks OK at first glance. However, I am missing the place where more details about the job at hand (what algorithm, what container limitations, what input data, what place to write the output to) can be specified. The message "BatchJobSpec" has some meta information but no space to actually specify more details.
Maybe I am missing context here? Do we have more documentation or design docs about the whole intended system?
geenen124
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.