Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endless rotation because of serviceAccount default #163

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Jun 7, 2018

This PR prevent and endless rotation of pods because it specifies an empty serviceAccountName and then finds a "different" serviceAcountName of "default".

@ewoutp ewoutp self-assigned this Jun 7, 2018
@ewoutp ewoutp requested a review from matthewvon June 7, 2018 09:11
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 9af8683 into master Jun 7, 2018
@ewoutp ewoutp deleted the bugfix/serviceAccountName-default-rotation branch June 7, 2018 09:16
@ewoutp ewoutp removed the 4 - Review label Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants