Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-509 Remove scale_down_candidate annotation #1471

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

jwierzbo
Copy link
Collaborator

@jwierzbo jwierzbo commented Nov 2, 2023

No description provided.

@jwierzbo jwierzbo requested a review from a team as a code owner November 2, 2023 20:00
@cla-bot cla-bot bot added the cla-signed label Nov 2, 2023
Copy link
Collaborator

@ajanikow ajanikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert all changes in public api, you can remove only internal parts

@jwierzbo jwierzbo force-pushed the GT-509-remove-scale-down-annotation branch from 352cd4a to 2fcdfee Compare November 3, 2023 12:40
pkg/apis/deployment/v1/conditions.go Outdated Show resolved Hide resolved
pkg/apis/deployment/v2alpha1/conditions.go Outdated Show resolved Hide resolved
@jwierzbo jwierzbo merged commit 57337fb into master Nov 3, 2023
3 checks passed
@jwierzbo jwierzbo deleted the GT-509-remove-scale-down-annotation branch November 3, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants